Closed Bug 56236 Opened 20 years ago Closed 14 years ago
possible to selectively allow chars into file upload control by disabling control onkeydown
Summary: possible to selectively allow chars into file upload control by disablling control onkeydown → possible to selectively allow chars into file upload control by disabling control onkeydown
I haven't really looked at the security of upload controls, other than the basic restriction on scripts that you mentioned, but I will give it a look.
Status: NEW → ASSIGNED
Very clever. Looks like it would be hard to make a practical exploit, though. Jesse, what's your feeling on how critical this is? ccing some people.
ccing some more people. Tom, do you think this is something to worry about?
I don't feel that this incarnation of the file upload control problem is critical for rtm, although I do think it could be exploited by a "porn site warning page". Please examine bug 57770 for rtm, though. My proposed fix for that bug would cover this bug.
Mass changing QA to ckritzer.
QA Contact: junruh → ckritzer
Mass changing milestone to Moz1.0 - stuff targeted for late spring/early summer.
Target Milestone: --- → mozilla1.0
Less important bugs retargeted to 0.9.9
Target Milestone: mozilla1.0 → mozilla0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.2
The testcase doesn't seem to work in Mozilla 1.2a on Linux.
The testcase still demonstrates the hole using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031108 Firebird/0.7+
think we ought to go the route of restricting to the file picker and having a pref for user turn off the read only behavior. and try to do this for 1.8a(2). over to dan. hyatt any chance of sharing what safari users think of being resticted to just a file picker?
Reassigning to dveditz, as I suspect chofmann meant to do...
Assignee: security-bugs → dveditz
Status: ASSIGNED → NEW
*** Bug 290478 has been marked as a duplicate of this bug. ***
*** Bug 304480 has been marked as a duplicate of this bug. ***
Tell me your are joking. This hole is now open for almost five years?! Despite the unquestionable low severity of this issue, this needs to be fixed with one of the next security releases. Since all kind of blogging and webbased applications are out there, entering large amounts of text into websites is a common behavior. Can someone of the security team please explain while this has been kept open so long?
This will be fixed in Firefox 1.5 Beta -- see bug 258875. Two reasons the fix took so long are (1) other browsers are also vulnerable and (2) the only real fix, not letting users edit the filename field directly, reduces usability in the non-attack case.
Whiteboard: [sg:fix] Patch in bug 258875 → [sg:high] Patch in bug 258875
I was wrong when I said "This will be fixed in Firefox 1.5 Beta". It is fixed on trunk (for Firefox 3 at least), but it wasn't fixed in Firefox 220.127.116.11. *** This bug has been marked as a duplicate of 258875 ***
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
This problem is currently getting publicity: http://www.derkeiler.com/Mailing-Lists/Full-Disclosure/2006-06/msg00144.html http://www.heise.de/newsticker/meldung/73933 Dex
You need to log in before you can comment on or make changes to this bug.