Closed
Bug 562435
Opened 15 years ago
Closed 15 years ago
RECENT_EVENT_THRESHOLD should be a PRTime in nsNavHistory
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
942 bytes,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
In member function ‘nsresult nsNavHistory::AddVisitChain
nsNavHistory.cpp:5384: warning: comparison between signed and unsigned integer expressions
In member function ‘PRBool nsNavHistory::CheckIsRecentEvent
nsNavHistory.cpp:6768: warning: comparison between signed and unsigned integer expressions
In member function ‘PRBool nsNavHistory::GetRedirectFor
nsNavHistory.cpp:6859: warning: comparison between signed and unsigned integer expressions
Attachment #442158 -
Flags: review? → review?(dietrich)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 442158 [details] [diff] [review]
patch
r=me, thanks!
Attachment #442158 -
Flags: review?(dietrich) → review+
|
||
Comment 3•15 years ago
|
||
hm, which compiler is generating those? I can't see anything similar in Linux
i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5646) (dot 1)
OS: All → Mac OS X
Hardware: All → x86_64
|
||
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in
before you can comment on or make changes to this bug.
Description
•