Closed Bug 562435 Opened 11 years ago Closed 11 years ago

RECENT_EVENT_THRESHOLD should be a PRTime in nsNavHistory

Categories

(Toolkit :: Places, defect)

x86_64
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

In member function ‘nsresult nsNavHistory::AddVisitChain
nsNavHistory.cpp:5384: warning: comparison between signed and unsigned integer expressions

In member function ‘PRBool nsNavHistory::CheckIsRecentEvent
nsNavHistory.cpp:6768: warning: comparison between signed and unsigned integer expressions

In member function ‘PRBool nsNavHistory::GetRedirectFor
nsNavHistory.cpp:6859: warning: comparison between signed and unsigned integer expressions
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #442158 - Flags: review?
Attachment #442158 - Flags: review? → review?(dietrich)
Comment on attachment 442158 [details] [diff] [review]
patch

r=me, thanks!
Attachment #442158 - Flags: review?(dietrich) → review+
hm, which compiler is generating those? I can't see anything similar in Linux
i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5646) (dot 1)
OS: All → Mac OS X
Hardware: All → x86_64
http://hg.mozilla.org/mozilla-central/rev/b3d1b7b30851
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.