562469 - e10s HTTP: provide way to know if channel servicing a top-level load

Status: RESOLVED WONTFIX

(Core :: Networking: HTTP, defect)

Description

[Jason Duell]

This should be just a matter of checking (mLoadFlags  &nsIChannel::LOAD_DOCUMENT_URI) &&  (mURI == mDocumentURI) in the child, and passing a flag with the result in AsyncOpen.

Patch coming soon.

Comment 1

[Jason Duell]

Attachment: Adds isTopLevelLoad attribute to nsIHttpChannelInternal

I assume I should put this in nsIHttpChannelInternal.   If we need something similar from FTP (it doesn't have an mDocumentURI, so I'm not sure how to dupe the logic), then we might want to have it in some common interface, but presently they don't share one that's a logical place for this.

I also assume it's ok to assign a bool to a PRBool, so long as my XPCOM interface doesn't mention bool.  Correct?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

So from our IRC discussion, it sounded like what you want is "may this trigger a download", and for that, you don't want top-level loads, you want all document loads. I.e., you want only LOAD_DOCUMENT_URI.

At that point however, you don't need a particular attribute, since the load flags are already passed to the parent (right?)

I'm not really sure that I like making HTTP channels know about download manager though...

(for the patch itself: the IDL would need a new IID, and in HttpBaseChannel::GetIsTopLevelLoad you want = instead of ==)

Comment 3

[Jason Duell]

Comment on attachment 442349 [details] [diff] [review]
Adds isTopLevelLoad attribute to nsIHttpChannelInternal

Canceling review, since it appear we don't need this after all.  Simply checking the channel's load flags for LOAD_DOCUMENT_URI will suffice for the Download manager, since it needs to capture not just top-level loads but <iframe>'s.