562488 - After playing an ogg audio file (or video with audio) (through oss) a segfauilt occurs

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Cliff Wright]

User-Agent:       Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.9.2.3) Gecko/20100412 Firefox/3.6.3
Build Identifier: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.9.2.3) Gecko/20100412

Bug tracked to a stream object being freed while in use.
File mozilla-1.9.2/media/libsydneyaudio/src/sydney_audio_oss.c
Also since the thread that is writing to the audio device is not waited for with a join the _POSIX_THREAD_THREADS_MAX is counted against on NetBSD.
In sa_stream_destroy, the steam object can be freed before the request to stop is serviced. The patch I used to fix this is :
--- sydney_audio_oss.c.sav      2010-04-12 13:21:06.000000000 -0700
+++ sydney_audio_oss.c  2010-04-28 14:40:04.000000000 -0700
@@ -258,6 +258,7 @@
 int
 sa_stream_destroy(sa_stream_t *s) {
   int result = SA_SUCCESS;
+  pthread_t thread_id_sav = s->thread_id;
 
   if (s == NULL) {
     return SA_SUCCESS;
@@ -281,6 +282,9 @@
 
   pthread_mutex_unlock(&s->mutex);
 
+  /* wait for thread to stop */
+  pthread_join(thread_id_sav, NULL);
+
   /*
    * Release resources.
    */

Reproducible: Always

Steps to Reproduce:
1.URL to firefox 3.6.3 file:///audiosample.ogg
2.
3.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: patch v0

Thanks, the patch looks good.  I've reformatted it a little and updated the update.sh/README_MOZILLA files in the attached patch.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

http://hg.mozilla.org/mozilla-central/rev/c34e4f1eb78a