Use Element in nsStyleAnimation::ComputeValue and nsSMILCSSValueType::ValueFromString

RESOLVED FIXED in mozilla5

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: bzbarsky, Assigned: Ms2ger)

Tracking

Trunk
mozilla5
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

Right now they take nsIContent, but taking Element would make more sense, I think.
Assignee

Updated

9 years ago
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Assignee

Comment 1

9 years ago
Attachment #471078 - Flags: review?(Olli.Pettay)
Assignee

Comment 2

9 years ago
Attachment #471079 - Flags: review?(Olli.Pettay)
Comment on attachment 471079 [details] [diff] [review]
Part c: nsStyleAnimation::ComputeValue v1

r=dbaron
Attachment #471079 - Flags: review?(Olli.Pettay) → review+
Attachment #471078 - Flags: review?(Olli.Pettay) → review+
Assignee

Comment 4

9 years ago
Thanks.
Whiteboard: [needs landing]
Assignee

Updated

9 years ago
Attachment #471079 - Attachment description: Part v: nsStyleAnimation::ComputeValue v1 → Part b: nsStyleAnimation::ComputeValue v1
Assignee

Updated

9 years ago
Attachment #471079 - Attachment description: Part b: nsStyleAnimation::ComputeValue v1 → Part c: nsStyleAnimation::ComputeValue v1
Assignee

Comment 5

9 years ago
Bug 598099 added another consumer…
Attachment #486868 - Flags: review?(bzbarsky)
Comment on attachment 486868 [details] [diff] [review]
Part b: nsDOMWindowUtils::ComputeAnimationDistance v1

r=me
Attachment #486868 - Flags: review?(bzbarsky) → review+
Assignee

Updated

9 years ago
Depends on: post2.0
Assignee

Comment 7

8 years ago
Attachment #471078 - Attachment is obsolete: true
Assignee

Comment 8

8 years ago
Attachment #486868 - Attachment is obsolete: true
Assignee

Comment 9

8 years ago
Attachment #471079 - Attachment is obsolete: true
Assignee

Updated

8 years ago
Keywords: checkin-needed
Whiteboard: [needs landing]

Comment 11

8 years ago
http://hg.mozilla.org/mozilla-central/rev/d2f3c03bed30
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
No longer depends on: post2.0
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2

Comment 13

8 years ago
http://hg.mozilla.org/mozilla-central/rev/f8aa658b3d39

(trying to maximize the amount of bugspam!  ;-))
You need to log in before you can comment on or make changes to this bug.