add support for styling headers based on HTML5 sectioning elements

RESOLVED FIXED in mozilla1.9.3a5

Status

()

defect
P3
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({html5})

Trunk
mozilla1.9.3a5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We should add rules to our UA style sheet reflecting the new outlining algorithm in HTML5.  In particular, the changes suggested by the rendering section of the HTML5 spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html
are straightforward to implement using :-moz-any().
Posted patch patch (obsolete) — Splinter Review
I still need to test this (and perhaps add an automated test) before requesting review.
Posted patch patchSplinter Review
Writing the test was useful; I caught the need for 'font: 1.00em' on the h4 rule.
Attachment #442571 - Attachment is obsolete: true
Attachment #442611 - Flags: review?(bzbarsky)
And I'm not expecting this to be a noticeable performance problem; it's about as bad as what we already do for li elements, and I think li elements are much more common than h1 elements.
Er, what we do for ul and ol elements.  Still, I think they're probably more common.
Comment on attachment 442611 [details] [diff] [review]
patch

r=bzbarsky
Attachment #442611 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/30c9289d5dad
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.