Closed Bug 562835 Opened 14 years ago Closed 14 years ago

add support for styling headers based on HTML5 sectioning elements

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: html5)

Attachments

(1 file, 1 obsolete file)

We should add rules to our UA style sheet reflecting the new outlining algorithm in HTML5.  In particular, the changes suggested by the rendering section of the HTML5 spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html
are straightforward to implement using :-moz-any().
Attached patch patch (obsolete) — Splinter Review
I still need to test this (and perhaps add an automated test) before requesting review.
Attached patch patchSplinter Review
Writing the test was useful; I caught the need for 'font: 1.00em' on the h4 rule.
Attachment #442571 - Attachment is obsolete: true
Attachment #442611 - Flags: review?(bzbarsky)
And I'm not expecting this to be a noticeable performance problem; it's about as bad as what we already do for li elements, and I think li elements are much more common than h1 elements.
Er, what we do for ul and ol elements.  Still, I think they're probably more common.
Comment on attachment 442611 [details] [diff] [review]
patch

r=bzbarsky
Attachment #442611 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/30c9289d5dad
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.