Closed
Bug 562855
Opened 15 years ago
Closed 15 years ago
hook_sqlite_mutex in test_true_async.cpp should check the return value from sqlite3_initialize() and sqlite3_shutdown()
Categories
(Core :: SQLite and Embedded Database Bindings, defect)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file, 1 obsolete file)
|
931 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
storage/test/test_true_async.cpp
doesn't check the return value from
sqlite3_initialize()
it can fail and is generally checked
|
||
Comment 2•15 years ago
|
||
Comment on attachment 442612 [details] [diff] [review]
patch
sure.
why aren't you adding a check for sqlite3_shutdown too? does it return failure?
Attachment #442612 -
Flags: review?(bugmail) → review+
|
||
Updated•15 years ago
|
Whiteboard: [timeless: needs answer to comment 2]
i'm not really systematically going through files or coverity issues... eventually i would have gotten to it :).
new patch coming
Summary: hook_sqlite_mutex in test_true_async.cpp should check the return value from sqlite3_initialize() → hook_sqlite_mutex in test_true_async.cpp should check the return value from sqlite3_initialize() and sqlite3_shutdown()
Whiteboard: [timeless: needs answer to comment 2]
Attachment #442612 -
Attachment is obsolete: true
Attachment #442979 -
Flags: review+
|
|
||
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
|
||
Updated•1 year ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•