hook_sqlite_mutex in test_true_async.cpp should check the return value from sqlite3_initialize() and sqlite3_shutdown()

RESOLVED FIXED in mozilla1.9.3a5

Status

()

Toolkit
Storage
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity})

Trunk
mozilla1.9.3a5
coverity
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

931 bytes, patch
timeless
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
storage/test/test_true_async.cpp
doesn't check the return value from
sqlite3_initialize()

it can fail and is generally checked
(Assignee)

Comment 1

8 years ago
Created attachment 442612 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #442612 - Flags: review?(bugmail)
Comment on attachment 442612 [details] [diff] [review]
patch

sure.

why aren't you adding a check for sqlite3_shutdown too?  does it return failure?
Attachment #442612 - Flags: review?(bugmail) → review+
Whiteboard: [timeless: needs answer to comment 2]
(Assignee)

Comment 3

8 years ago
i'm not really systematically going through files or coverity issues... eventually i would have gotten to it :).

new patch coming
Summary: hook_sqlite_mutex in test_true_async.cpp should check the return value from sqlite3_initialize() → hook_sqlite_mutex in test_true_async.cpp should check the return value from sqlite3_initialize() and sqlite3_shutdown()
Whiteboard: [timeless: needs answer to comment 2]
(Assignee)

Comment 4

8 years ago
Created attachment 442979 [details] [diff] [review]
and _shutdown()
Attachment #442612 - Attachment is obsolete: true
Attachment #442979 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/07aa5d457ff1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.