Add Hg changeset and repo information to the plist and remove unnecessary platform.ini generation

RESOLVED FIXED in Camino2.1

Status

Camino Graveyard
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: Smokey Ardisson (offline for a while; not following bugs - do not email))

Tracking

1.9.2 Branch
Camino2.1
All
Mac OS X
Dependency tree / graph

Details

Attachments

(1 attachment)

Created attachment 442622 [details] [diff] [review]
Makefile galore!

Spinning this off from bug 553139, because I haven't figured out what I want to do about the existing keys (specifically the CVS_TAG issue in bug 553139 comment 4 and bug 553139 comment 5), but I have this part working and it would benefit from a cleaner bug.

This patch does two things:

1) Removes our efforts to generate a platform.ini file; we had to generate it ourselves before because we didn't build in toolkit/xre before; now we build everywhere, whether we want to or not :P and toolkit/xre generates a platform.ini file for us.

This also lets us remove the entire GARBAGE variable, since there are no single, stand-alone files that we generate any more that we need to clean up.

2) Adds the sets of rules required to get the changeset and Hg repository names and put them in the plist for safekeeping.  The mechanics are copy/paste of the existing CVS_TAG/TIME stuff, while the Hg commands to extract the data are copies of code elsewhere in the tree (s/topsrcdir/srcdir/ for the Camino ones).

Per our plist key alphabetization policy, the new keys have been inserted where they would appear visually when Property List Editor displays the file (this is not the same place they appear in the actual plist as viewed by Quick Look or in a text editor, since the file uses a different alphabetization algorithm).
Attachment #442622 - Flags: superreview?(stuart.morgan+bugzilla)
Target Milestone: --- → Camino2.1
Blocks: 560323

Comment 1

8 years ago
Comment on attachment 442622 [details] [diff] [review]
Makefile galore!

sr=smorgan
Attachment #442622 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
http://hg.mozilla.org/camino/rev/2d74a405dc57
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.