Closed Bug 562872 Opened 13 years ago Closed 13 years ago

encapsulate Arguments-related dslots accesses

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
10.29 KB, patch
brendan
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
All very straightforward... a quick patch last thing on my Friday afternoon.
Attachment #442635 - Flags: review?(brendan)
Comment on attachment 442635 [details] [diff] [review]
patch

Looks good -- at some point (some other bug) we talked about abstracting the details of deleted-element representation (JSVAL_HOLE). No good? Or separate bug?

/be
Attachment #442635 - Flags: review?(brendan) → review+
(In reply to comment #1)
> Looks good -- at some point (some other bug) we talked about abstracting the
> details of deleted-element representation (JSVAL_HOLE). No good? Or separate
> bug?

I'd forgotten about that, but Bugzilla hadn't: bug 558706.
http://hg.mozilla.org/tracemonkey/rev/c3ee09da6532
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/c3ee09da6532
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.