562925 - Check for Updates link in details view missed visual feedback

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Tony Chung [:tchung]]

The check for updates button within the extension details needs to return some sort of alert or notification when clicked on.   If there is no updates returned, at least show the user a popup or something.   Currently, clicking it does nothing, and does not intuitively tell the user if this functionality is working or not.  

1) install nightly Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre
2) install any up to date extension (eg. weave or quick fox notes)
3) restart, and double click your installed extension
4) uncheck "Update automatically" checkbox
5) click the "Check for Updates" button below it
6) Verify there is no user feedback or notification that something has happened.   If there is no updates for real, then at least show something to the user.

Expected:
- some kind of notification if no updates are returned when clicking the "check for updates" button

Actual:
- clicking it shows nothing, and can be misled to be a broken functionality.

Comment 1

[Tony Chung [:tchung]]

Looks like this is actually busted behavior.   I had an installed addon that i know has an update (installed weave 1.2), and clicking the button should have given me an update (weave 1.2.3).   instead, no response on click.

Changing title to reflect the new broken behavior.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The update button is a placeholder at the moment. There is no action behind it. This bug should be fixed for bug 562902.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #2)
> The update button is a placeholder at the moment. There is no action behind it.

To clarify: Clicking the button should indeed check for (and install) updates. But there is currently no feedback that anything is happening.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #4)
> To clarify: Clicking the button should indeed check for (and install) updates.
> But there is currently no feedback that anything is happening.

This is still a problem which needs to be solved. What should happen when an user clicks onto the link? Shall we show the "Check for updates" text in the header?

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #5)
> This is still a problem which needs to be solved. What should happen when an
> user clicks onto the link? Shall we show the "Check for updates" text in the
> header?

It should do what the list view does, which is:
* Show "Checking for updates"
* If there's an update found, and its set to update automatically, show the download status
* If there's an update found, and its set to update manually, show an "Update now" button

Its just a matter of hooking all this up. We already have all the strings, etc.

Comment 7

[Dietrich Ayala (:dietrich)]

Attachment: wip

basic stuff in place. the no-update scenario works. need to handle the complete update scenario still. the test is just a copy that i've started to modify, nothing to look at yet.

Dave: i'm new to this code - can you take a peek to see if i'm on the right path here?

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 501654 [details] [diff] [review]
wip

Deferring to Blair as he'll probably be reviewing this one anyway

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 501654 [details] [diff] [review]
wip

Yep, looks like that'll work nicely.

Comment 10

[Dietrich Ayala (:dietrich)]

Attachment: more

Comment 11

[Dietrich Ayala (:dietrich)]

Attachment: more

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

** PRODUCT DRIVERS PLEASE NOTE **

This bug is one of 7 automatically changed from blocking2.0:final+ to blocking2.0:.x during the endgame of Firefox 4 for the following reasons:

 - it was marked as a soft blocking issue without a requirement for beta coverage

Comment 14

[Dietrich Ayala (:dietrich)]

Not working on this. Someone with more experience in this could get it all hooked up the rest of the way far faster than I.

(Also, there are a LOT of moving pieces in the AOM UI code. Would be great to kill all the XBL extra dead, and just use JS. Would really simplify things.)

Comment 16

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.