Third party themes is breaking the layout of Addons Manager

RESOLVED INVALID

Status

()

defect
RESOLVED INVALID
9 years ago
2 years ago

People

(Reporter: tchung, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [AddonsRewriteTestday][rewrite], URL)

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
When installing a AMO-hosted third party theme like Walnut, Tiger Woods, it can affect the layout and design of addons manager.   

See screenshots for examples

Repro
1) install nightly Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre
2) goto AMO, search and install 3rd party themes (eg. walnut, tiger woods)
3) restart with the new theme
4) Verify layout, images, favicons, buttons, etc.. seems busted from the original intended design of addons manager

Expected:
- 3rd party themes should not affect addons manager layout and functionality
(Reporter)

Comment 1

9 years ago
Why should 3rd party themes not affect the display of the add-ons manager?
(Reporter)

Comment 3

9 years ago
i guess functionality breaks it; so maybe its an evangelism thing.  for example, i had more addons installed on the screen using the TIger woods theme. but the scrollbar broke, so i was unable to get to the bottom of my extension list to do anything with it.
I think there are some parts of the functionality that needs to be pulled out of the default theme which will probably help make it so themes don't break functionality but otherwise I think they should be free to style things.
(Reporter)

Comment 5

9 years ago
that sounds like the right approach.  we can spin this bug that direction if you dont already have a tracking one.

Things that i notice that are breakage so far are:
- menu favicons are missing, and replaced with a "0"
- unable to scroll down to more extensions, past what's shown in the window
- the space for where discovery pane notification thats coming isnt shown.  just a blank empty space
- plugin icons are gone

Thats what i observe for now.
OS: Mac OS X → All
Hardware: x86 → All
Also: the left column (name & icon) of the main pane is too wide, cramping out the right column (field values & buttons).

I saw this also on SeaMonkey 2.1a2pre dated 2010-05-13 on Linux with the EarlyBlue theme, see bug 561600 comment #27 and attachment 445291 [details]; however the scrollbar was present.
IIUC the Modern theme *shipped with SeaMonkey* (see attachment #445647 [details]) is one of those "third-party" themes which need to borrow some stuff from the default theme.

Comment 8

2 years ago
With the end of heavy weight themes, assuming this is no longer valid.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.