563036 - Install VC 2005 SP1 redist on Windows XP rev3 machines

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[alice nodelman [:alice] [:anode]]

eg: C:\talos-slave\mozilla-central-xp-opt-u-mochitests-1\build 

INFO | runtests.py | Server pid: 1336
INFO | runtests.py | Performing extension manager registration: start.

INFO | automation.py | Application pid: 3336
INFO | automation.py | Application ran for: 0:00:02.579000
INFO | automation.py | Reading PID log: c:\docume~1\cltbld\locals~1\temp\tmphjbwrmpidlog

INFO | runtests.py | Performing extension manager registration: end.


INFO | runtests.py | Running tests: start.

Traceback (most recent call last):
  File "mochitest/runtests.py", line 653, in <module>
  File "mochitest/runtests.py", line 650, in main
  File "mochitest/runtests.py", line 540, in runTests
  File "C:\talos-slave\mozilla-central-xp-opt-u-mochitests-1\build\mochitest\automation.py", line 707, in runApp
    certificateStatus = self.fillCertificateDB(profileDir, certPath, utilityPath, xrePath)
  File "C:\talos-slave\mozilla-central-xp-opt-u-mochitests-1\build\mochitest\automation.py", line 422, in fillCertificateDB
    status = self.Process([certutil, "-N", "-d", profileDir, "-f", pwfilePath], env = env).wait()
  File "C:\talos-slave\mozilla-central-xp-opt-u-mochitests-1\build\mochitest\automation.py", line 160, in __init__
    universal_newlines, startupinfo, creationflags)
  File "C:\mozilla-build\Python25\lib\subprocess.py", line 593, in __init__
    errread, errwrite)
  File "C:\mozilla-build\Python25\lib\subprocess.py", line 793, in _execute_child
    startupinfo)
WindowsError: [Error 22] This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem

Looks like it starts running, but then is unable to proceed due to a missing library dependency - since this is an opt unit tests this is an unexpected error (we know that debug unit tests depend upon visual studio dlls that are not present).

Comment 1

[alice nodelman [:alice] [:anode]]

Looks like we don't have 'certutil' on our winxp talos boxes... investigating how to get it.

Comment 2

[alice nodelman [:alice] [:anode]]

Okay, certutil is there, except when I try

certutil -N

Unknown arg: -N

Comment 3

[(not currently active) Ted Mielczarek]

If you look at the source:
http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#466

You'll see that it tries to run certutil from utilityPath, which should be "bin/" from the test package.

Comment 4

[alice nodelman [:alice] [:anode]]

Did fine out I was missing:

smime3.dll
msvcr80.dll

But still haven't gotten a successful run out of this.

Comment 5

[alice nodelman [:alice] [:anode]]

Other things that I've tried:

Vcredist_x86.exe (2005 & 2008) for visual studio run time environment

Comment 6

[alice nodelman [:alice] [:anode]]

Pushing to joduinn.

Comment 7

[Armen [:armenzg]]

I won't be able to touch this for a while. Check with me if you think I should pick this work ASAP over the other bugs I am already working on.

Comment 8

[Armen [:armenzg]]

I have not being able to pick up this at all but I might be able to do so in 4-5 weeks.

Is this a bug that the automation tools could figure out?

Comment 9

[Armen [:armenzg]]

To note that I have neither tried to debug this myself nor verify it.

I have updated the summary of the bug to match what is going on.
Even though I say "Rev3" machines it might be that we just can't run unit tests at all on XP.
We deployed MozillaBuild since comment 6 so things might have changed. I will give it a whirl this week to "just verify" that this it is still happening and I won't be trying to debug it and figure out why we can't run it.

After talking with beltzner we want this for betaN since we don't want to go out completely blind. This means that we should have this fixed before EOQ or early next quarter.

Comment 10

[(not currently active) Ted Mielczarek]

If you can give me access to one of these machines I could certainly take a look and try to figure out what's going on.

Comment 11

[Chris Cooper [:coop] (he/him)]

(In reply to comment #10)
> If you can give me access to one of these machines I could certainly take a
> look and try to figure out what's going on.

Let me set that up for you. I'll send details when it's ready.

Comment 12

[Chris Cooper [:coop] (he/him)]

Sent Ted login credentials for talos-r3-xp-002.

Comment 13

[(not currently active) Ted Mielczarek]

(In reply to comment #5)
> Other things that I've tried:
> 
> Vcredist_x86.exe (2005 & 2008) for visual studio run time environment

I was able to get this to work by installing:
http://www.microsoft.com/downloads/details.aspx?familyid=200b2fd9-ae1a-4a14-984d-389c36f85647&displaylang=en

(Note this is VC 2005 *SP1* redist, which matches the compiler we use.)

Comment 14

[Chris Cooper [:coop] (he/him)]

Attachment: Add Visual C++ 2005 SP1 redist package to OPSI

This is based on the commands found at AppDeploy.com (http://www.appdeploy.com/packages/detail.asp?id=1345). Tested in staging using talos-r3-xp-001. 

Here's the output from the config editor log:

Execution of Winbatch_install_vc2005sp1_redist
  Call "msiexec /i P:\install\vc2005sp1_redist\vcredist.msi /qn /l*v "c:\tmp\vcredist_x86.log""
     Waiting until the called process is finished
  ExitCode 0    Executed process "msiexec /i P:\install\vc2005sp1_redist\vcredist.msi /qn /l*v "c:\tmp\vcredist_x86.log""

There's also the output log (~2MB) on talos-r3-xp-001 if you're curious (C:\tmp\vcredist_x86.log).

Comment 15

[[e-mail] (:bhearsum)]

Comment on attachment 468455 [details] [diff] [review]
Add Visual C++ 2005 SP1 redist package to OPSI

Looks fine to me. I'm super pleased that it has a non-interactive install option!

Comment 16

[Chris Cooper [:coop] (he/him)]

Comment on attachment 468455 [details] [diff] [review]
Add Visual C++ 2005 SP1 redist package to OPSI

http://hg.mozilla.org/build/opsi-package-sources/rev/95396be165c7

Comment 17

[Chris Cooper [:coop] (he/him)]

I've marked all the production talos rev3 xp machines to install the new package at next reboot.

Comment 18

[Chris Cooper [:coop] (he/him)]

Resurrected a bunch of XP slaves today that hadn't updated in a while. 

Modulo talos-r3-xp-053 which has a different issue covered in bug 591991, all the r3 xp slaves have this installed now.

Comment 19

[alice nodelman [:alice] [:anode]]

That would not include the tool staging talos slaves are they are not connected to opsi.