need make package-tests target

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: bear, Unassigned)

Tracking

Trunk
x86
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
package-tests target does not exists and is required for nightly builds
(Reporter)

Updated

8 years ago
Blocks: 560911

Updated

8 years ago
Blocks: 561908

Updated

8 years ago
Depends on: 562461

Comment 1

8 years ago
This will block unit tests on Android (as well as bug 562461).

Comment 2

8 years ago
That should be bug 563097.
Depends on: 563097
No longer depends on: 562461

Updated

8 years ago
Depends on: 563437

Comment 3

8 years ago
We should probably morph this to specify that we need to make a decision re: the NDK?

Comment 4

7 years ago
Created attachment 457460 [details] [diff] [review]
Provides a package test target that contains sutagent apk file

I'm not sure if this is the correct bug, but I'm thinking it is.  This patch provides a package-test target for Android that will contain the sutagent apk installation file as well as all the standard tests and binaries for android.

Steps to use:
1. Run a build on Android using a mozconfig with --enable-tests
2. After build cd to OBJDIR run make package-tests

The sutAgentAndroid.apk will be in the bin/ directory of the packaged tests.
Attachment #457460 - Flags: review?(ted.mielczarek)
the usage looks correct and a quick look at the patch seems pretty good...I know I am not the reviewer, so I will let ted be the official spokesperson :)

Comment 6

7 years ago
Comment on attachment 457460 [details] [diff] [review]
Provides a package test target that contains sutagent apk file

>diff --git a/testing/testsuite-targets.mk b/testing/testsuite-targets.mk
>+stage-android: make-stage-dir
>+	$(NSINSTALL) $(DEPTH)/build/mobile/sutagent/android/sutAgentAndroid.apk $(PKG_STAGE)/bin/sutAgentAndroid.apk
This ^ line should be: $(NSINSTALL) $(DEPTH)/build/mobile/sutagent/android/sutAgentAndroid.apk $(PKG_STAGE)/bin

I'll factor that in before checking in, hardly seems worth a new patch, but it definitely makes a difference :)
Comment on attachment 457460 [details] [diff] [review]
Provides a package test target that contains sutagent apk file

>diff --git a/testing/testsuite-targets.mk b/testing/testsuite-targets.mk
>--- a/testing/testsuite-targets.mk
>+++ b/testing/testsuite-targets.mk
>@@ -120,12 +120,19 @@
> 	  $(TEST_PATH_ARG) $(EXTRA_TEST_ARGS) \
> 	  $(DIST)/bin/xpcshell
> 
>+TEST_STAGE_LIST = stage-mochitest stage-reftest stage-xpcshell stage-jstests stage-mozmill
>+
>+# Package our sutagent 
>+ifeq (Android,$(OS_TARGET))
>+TEST_STAGE_LIST += stage-android
>+endif

You don't really need to put this into a variable, you can just keep the existing:
package-tests: stage-mochitest stage-reftest stage-xpcshell stage-jstests stage-mozmill

and add:
ifeq (Android,$(OS_TARGET))
package-tests: stage-android
endif

(you can just unconditionally list stage-android in .PHONY, it doesn't matter much)

r=me with that change.
Attachment #457460 - Flags: review?(ted.mielczarek) → review+

Comment 8

7 years ago
http://hg.mozilla.org/mozilla-central/rev/11e50fc822a1 -->FIXED
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.