Closed Bug 563095 Opened 14 years ago Closed 14 years ago

need make package-tests target

Categories

(Firefox Build System :: General, defect)

x86
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bear, Unassigned)

References

Details

Attachments

(1 file)

package-tests target does not exists and is required for nightly builds
Blocks: 560911
Blocks: 561908
Depends on: 562461
This will block unit tests on Android (as well as bug 562461).
That should be bug 563097.
Depends on: 563097
No longer depends on: 562461
Depends on: 563437
We should probably morph this to specify that we need to make a decision re: the NDK?
I'm not sure if this is the correct bug, but I'm thinking it is.  This patch provides a package-test target for Android that will contain the sutagent apk installation file as well as all the standard tests and binaries for android.

Steps to use:
1. Run a build on Android using a mozconfig with --enable-tests
2. After build cd to OBJDIR run make package-tests

The sutAgentAndroid.apk will be in the bin/ directory of the packaged tests.
Attachment #457460 - Flags: review?(ted.mielczarek)
the usage looks correct and a quick look at the patch seems pretty good...I know I am not the reviewer, so I will let ted be the official spokesperson :)
Comment on attachment 457460 [details] [diff] [review]
Provides a package test target that contains sutagent apk file

>diff --git a/testing/testsuite-targets.mk b/testing/testsuite-targets.mk
>+stage-android: make-stage-dir
>+	$(NSINSTALL) $(DEPTH)/build/mobile/sutagent/android/sutAgentAndroid.apk $(PKG_STAGE)/bin/sutAgentAndroid.apk
This ^ line should be: $(NSINSTALL) $(DEPTH)/build/mobile/sutagent/android/sutAgentAndroid.apk $(PKG_STAGE)/bin

I'll factor that in before checking in, hardly seems worth a new patch, but it definitely makes a difference :)
Comment on attachment 457460 [details] [diff] [review]
Provides a package test target that contains sutagent apk file

>diff --git a/testing/testsuite-targets.mk b/testing/testsuite-targets.mk
>--- a/testing/testsuite-targets.mk
>+++ b/testing/testsuite-targets.mk
>@@ -120,12 +120,19 @@
> 	  $(TEST_PATH_ARG) $(EXTRA_TEST_ARGS) \
> 	  $(DIST)/bin/xpcshell
> 
>+TEST_STAGE_LIST = stage-mochitest stage-reftest stage-xpcshell stage-jstests stage-mozmill
>+
>+# Package our sutagent 
>+ifeq (Android,$(OS_TARGET))
>+TEST_STAGE_LIST += stage-android
>+endif

You don't really need to put this into a variable, you can just keep the existing:
package-tests: stage-mochitest stage-reftest stage-xpcshell stage-jstests stage-mozmill

and add:
ifeq (Android,$(OS_TARGET))
package-tests: stage-android
endif

(you can just unconditionally list stage-android in .PHONY, it doesn't matter much)

r=me with that change.
Attachment #457460 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/11e50fc822a1 -->FIXED
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: