Closed
Bug 563095
Opened 16 years ago
Closed 16 years ago
need make package-tests target
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bear, Unassigned)
References
Details
Attachments
(1 file)
|
1.38 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
package-tests target does not exists and is required for nightly builds
Comment 1•16 years ago
|
||
This will block unit tests on Android (as well as bug 562461).
Comment 2•16 years ago
|
||
That should be bug 563097.
Comment 3•16 years ago
|
||
We should probably morph this to specify that we need to make a decision re: the NDK?
I'm not sure if this is the correct bug, but I'm thinking it is. This patch provides a package-test target for Android that will contain the sutagent apk installation file as well as all the standard tests and binaries for android.
Steps to use:
1. Run a build on Android using a mozconfig with --enable-tests
2. After build cd to OBJDIR run make package-tests
The sutAgentAndroid.apk will be in the bin/ directory of the packaged tests.
Attachment #457460 -
Flags: review?(ted.mielczarek)
Comment 5•16 years ago
|
||
the usage looks correct and a quick look at the patch seems pretty good...I know I am not the reviewer, so I will let ted be the official spokesperson :)
Comment on attachment 457460 [details] [diff] [review]
Provides a package test target that contains sutagent apk file
>diff --git a/testing/testsuite-targets.mk b/testing/testsuite-targets.mk
>+stage-android: make-stage-dir
>+ $(NSINSTALL) $(DEPTH)/build/mobile/sutagent/android/sutAgentAndroid.apk $(PKG_STAGE)/bin/sutAgentAndroid.apk
This ^ line should be: $(NSINSTALL) $(DEPTH)/build/mobile/sutagent/android/sutAgentAndroid.apk $(PKG_STAGE)/bin
I'll factor that in before checking in, hardly seems worth a new patch, but it definitely makes a difference :)
Comment 7•16 years ago
|
||
Comment on attachment 457460 [details] [diff] [review]
Provides a package test target that contains sutagent apk file
>diff --git a/testing/testsuite-targets.mk b/testing/testsuite-targets.mk
>--- a/testing/testsuite-targets.mk
>+++ b/testing/testsuite-targets.mk
>@@ -120,12 +120,19 @@
> $(TEST_PATH_ARG) $(EXTRA_TEST_ARGS) \
> $(DIST)/bin/xpcshell
>
>+TEST_STAGE_LIST = stage-mochitest stage-reftest stage-xpcshell stage-jstests stage-mozmill
>+
>+# Package our sutagent
>+ifeq (Android,$(OS_TARGET))
>+TEST_STAGE_LIST += stage-android
>+endif
You don't really need to put this into a variable, you can just keep the existing:
package-tests: stage-mochitest stage-reftest stage-xpcshell stage-jstests stage-mozmill
and add:
ifeq (Android,$(OS_TARGET))
package-tests: stage-android
endif
(you can just unconditionally list stage-android in .PHONY, it doesn't matter much)
r=me with that change.
Attachment #457460 -
Flags: review?(ted.mielczarek) → review+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•