563134 - Can't set up Weave account with new Extension Manager

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre RTSE/1.2.0.20100406
Build Identifier: 

When I try to log in to Weave with my Weave account, you can go through the entire wizard, and everything works fine until you get to the last screen.

The "Finish" button doesn't do anything when clicked. (The wizard stays open.) 

You can close the wizard with the window's 'X' button in the titlebar. If you do this, you can manually start a sync, and it will look like it worked, but the next time you start Firefox, it will ask you to set up your Weave account again.

Looking in the error console, it was throwing some error about "Application.extensions" not being defined in chrome/content/preferences/fx-setup.js every time I clicked on that "Finish" button.

From what I saw, Weave uses the extension service to see if NoScript is installed/running, and does some stuff if it is.

But with the extension manager rewrite, it must have broken some stuff.

Reproducible: Always

Steps to Reproduce:
1. Update to a trunk build with the newly landed extension manager rewrite.
2. Install Weave
3. (Install NoScript?)
4. Click the "Set up Weave" button down in the statusbar.
5. In the wizard, fill out the information (I used a previous account. I don't know if it does the same problem if you create a new account.)
6. Get to the end of the wizard. Try to click the "Finish" button.
7. See that the "Finish" button doesn't work.
8. Restart Firefox. See that Weave wants you to set up your account again.
Actual Results:  
Finish button doesn't work, and Weave doesn't seem to remember your account on restart. (Checking Weave's activity log, it also looks like some things don't get synced.)

Expected Results:  
Wizard should exit successfully. Weave should remember your account details.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Patch

These are the changes I made to get it working. Whether I got it working correctly (I'm not really sure what it does to NoScript, so I don't know if it does it), I don't know, but it does let me finish the set up wizard.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: /content/preferences/fx-setup.js

This is what my changed version of fx-setup.js looks like.

Comment 3

[Ed Lee :Mardak]

Thanks for the patch. We'll need to still support Firefox 3.5 users, so we can't take the patch directly.

mconnor, maybe we should just check for the contract id instead of seeing if it's enabled by the add-on manager. It shouldn't be registering if the whole add-on is disabled.

Comment 4

[Mike Connor [:mconnor]]

Did FUEL break compat here?  Using FUEL should prevent this from being an issue... what am I missing?

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #4)
> Did FUEL break compat here?  Using FUEL should prevent this from being an
> issue... what am I missing?

FUEL is changing a bit as well. http://www.oxymoronical.com/blog/2010/03/How-were-breaking-some-extensions-in-the-near-future

"Previously to get an add-ons version you might have done:

alert(Application.extensions.get("[e-mail]").version);

Now you will have to do:

Application.getExtensions(function(extensions) {
  alert(extensions.get("[e-mail]").version);
});
"

Comment 6

[Dave Townsend [:mossop]]

(In reply to comment #4)
> Did FUEL break compat here?  Using FUEL should prevent this from being an
> issue... what am I missing?

We ended up having to make an API breaking change to FUEL since we couldn't find any way to wrap the new add-on manager's asynchronous API with FUELs synchronous API without spinning an event loop, which people smarter than me say is a bad thing to do.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: New FUEL patch

This patch uses the FUEL API, instead of the AddonManager.

I haven't tested this patch, because I don't have time to start up a new profile to run the Weave setup.

Is "if(Application.extensions)" the correct way to check to see which version to use?

Comment 8

[Ed Lee :Mardak]

Attachment: v3

This isn't quite an issue right now as the new extension manager has been backed out. But this should make things more robust without having to explicitly check for old or new extension managers.

Comment 9

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/9b4f6ed25edf
Check for the NoScript contract id to determine if it's active instead of asking the extension manager. 

Thanks for digging into this Wes!