deprecated conversion from string constant to char* in nsAuthSambaNTLM::SpawnNTLMAuthHelper

RESOLVED FIXED in mozilla16

Status

()

Core
Networking
--
trivial
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
extensions/auth/nsAuthSambaNTLM.cpp: In member function ‘nsresult nsAuthSambaNTLM::SpawnNTLMAuthHelper()’:
nsAuthSambaNTLM.cpp:213:
 warning: deprecated conversion from string constant to ‘char*’
 warning: deprecated conversion from string constant to ‘char*’
 warning: deprecated conversion from string constant to ‘char*’
 warning: deprecated conversion from string constant to ‘char*’
 warning: deprecated conversion from string constant to ‘char*’

    char* args[] = {
        "ntlm_auth",
        "--helper-protocol", "ntlmssp-client-1",
        "--use-cached-creds",
        "--username", const_cast<char*>(username),
        nsnull
    };

this should be const char * const args[], however we can't do that today because the NSPR prototype isn't friendly (see blocker bug).
(Assignee)

Updated

7 years ago
Depends on: 563192
(Assignee)

Comment 1

7 years ago
Created attachment 442950 [details] [diff] [review]
patch

this can't be reviewed or pushed until the blocking bug is fixed.
Assignee: nobody → timeless
Status: NEW → ASSIGNED

Updated

7 years ago
Duplicate of this bug: 576659

Updated

6 years ago
Duplicate of this bug: 666619
There is a patch in the blocking bug (bug 563192), which has gone unreviewed for over a year.  I have pinged it.  I don't know if there is anything else that can be done to get this unjammed.
(In reply to comment #4)
> There is a patch in the blocking bug (bug 563192), which has gone unreviewed
> for over a year.  I have pinged it.  I don't know if there is anything else
> that can be done to get this unjammed.

A few suggestions that were made:
  o poking people is good
  o finding component/module owners and poking them
  o and if important, poking product drivers
  o something to bring up at various triage meetings.
  - there are flags you can set that make it show up for various triage meetings as well.

Updated

6 years ago
Whiteboard: [build_warnings]

Updated

6 years ago
Whiteboard: [build_warnings] → [build_warning]

Updated

6 years ago
Blocks: 187528
Created attachment 640932 [details] [diff] [review]
patch 2

How about this instead?  (Saw this clang warning flying by and thought I'd grab it.)
Attachment #640932 - Flags: review?(ehsan)
Attachment #640932 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f14591911ad8

Updated

5 years ago
Attachment #640932 - Attachment is patch: true

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f14591911ad8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.