563237 - Download link on XP Browser Choice screen is 404ing

Status: RESOLVED FIXED

(Webtools :: Bouncer, defect)

Description

[Peter Hewitt]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

Having just reformatted my netbook the browser choice screen popped up, so being lazyI thought I'd install Firefox that way rather than having to go to the site. However upon clicking the link I got a mozilla-europe 404 page and not a particularly friendly one at that. 

This would probably cause less savvy people to ignore the option and stick with ie

Reproducible: Always

Steps to Reproduce:
1. go to browserballot.eu
2. click on install link for firefox
3. see 404 and cry
Actual Results:  
404 error

Expected Results:  
download link

Comment 1

[Jo Hermans]

it's not browserballot.eu, it's <http://www.browserchoice.eu/>

<http://go.microsoft.com/fwlink/?LinkID=166930> sometimes redirects correctly, sometimes it doesn't. It might be a temporary error on either Microsoft's redirect server or Mozilla's one.

<http://download-eu.mozilla.org/?product=firefox-3.6.3-euballot&os=win&lang=en-GB> is indeed incorrect, it should be <http://download-eu.mozilla.org/?product=firefox-3.6.3&os=win&lang=en-GB>

Comment 2

[Jo Hermans]

oops, Microsoft's forward link should be <http://go.microsoft.com/fwlink/?LinkID=166932>

Comment 3

[Peter Hewitt]

Yes apologies for getting the URL wrong, I typed it all in a rush hence the general shoddyness of my opening post. Ahem.

Worth noting that changing the language URL on the MS page e.g.
http://www.browserchoice.eu/BrowserChoice/browserchoice_fr.htm
http://www.browserchoice.eu/BrowserChoice/browserchoice_de.htm

all use 166932 as the LinkID URL, so the sniffing for the appropriate language seemlingly happens at the Mozilla end.

Comment 4

[Nickolay_Ponomarev]

the microsoft page redirects to http://download-eu.mozilla.org/?product=firefox-latest-euballot&os=win&lang=en-GB for me, which then redirects to http://download-eu.mozilla.org/?product=firefox-3.6.3-euballot&os=win&lang=en-GB, which is 404.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #1)
> <http://download-eu.mozilla.org/?product=firefox-3.6.3-euballot&os=win&lang=en-GB>
> is indeed incorrect, it should be
> <http://download-eu.mozilla.org/?product=firefox-3.6.3&os=win&lang=en-GB>

No, it should be firefox-3.6.3-euballot. Looking into why it's a 404.

Comment 6

[Dave Miller [:justdave]]

Locale munging stuff from production got lost when we migrated to the new bouncer apparently.  Given the criticality of this I'm going to fix it without waiting for webdev, but getting it to the correct component anyway.

Comment 7

[Dave Miller [:justdave]]

on second thought, I had some family stuff come up, so if someone else wants to grab this, feel free, otherwise I'll get back to it in an hour or two.  nthomas knows what needs to be fixed, so he can show you.

Comment 8

[Dave Miller [:justdave]]

nevermind, cleared up faster than I thought it would, I'm back on it.  Should have the fix committed shortly.

Comment 9

[Dave Miller [:justdave]]

Checking /firefox/releases/3.6.3/win32-EUBallot/sv-SE/Firefox Setup 3.6.3.exe... okay.

Link should be working now.

Comment 10

[Dave Miller [:justdave]]

Attachment: Patch v1

- restore Thunderbird locale fudging that got lost
- fix broken euballot locale fudging test

Comment 11

[Dave Miller [:justdave]]

Comment on attachment 443019 [details] [diff] [review]
Patch v1

This is already tested in production, but getting review just for the paperwork since nobody other than me has looked at it.

Comment 12

[Fred Wenzel [:wenzel]]

Comment on attachment 443019 [details] [diff] [review]
Patch v1

Looks good, just making sure though: For Thunderbird you don't want Ukranian at all anymore, but Turkish if it's version 3.1a1, Chinese/Taiwan otherwise?

Comment 13

[Dave Miller [:justdave]]

(In reply to comment #11)
> (From update of attachment 443019 [details] [diff] [review])
> This is already tested in production, but getting review just for the paperwork
> since nobody other than me has looked at it.

Should double-check with gozer on that I guess...  that's what was in the production sentry before the upgrade anyway.

Comment 14

[Dave Miller [:justdave]]

(In reply to comment #12)
> (From update of attachment 443019 [details] [diff] [review])
> Looks good, just making sure though: For Thunderbird you don't want Ukranian at
> all anymore, but Turkish if it's version 3.1a1, Chinese/Taiwan otherwise?

er, gozer: ^^^ that's what I meant to quote.

Comment 15

[Philippe M. Chiasson (:gozer)]

(In reply to comment #14)
> (In reply to comment #12)
> > (From update of attachment 443019 [details] [diff] [review] [details])
> > Looks good, just making sure though: For Thunderbird you don't want Ukranian at
> > all anymore, but Turkish if it's version 3.1a1, Chinese/Taiwan otherwise?

Yup. That's correct as of now, including the upcoming 3.1b2

Comment 16

[Dave Miller [:justdave]]

which is including 3.2b2?  The Turkish or the Chinese/Taiwan?

Comment 17

[Dave Miller [:justdave]]

Guess we'll run with that.

Sending        sentry/sentry.pl
Transmitting file data .
Committed revision 66822.

Comment 18

[Fred Wenzel [:wenzel]]

Merged upstream into tuxedo in: http://github.com/fwenzel/tuxedo/commit/a1137e49103283ca5cffdb9b61c7b1b7eac750aa

Guys, as long as you require an SVN mirror of tuxedo, you should upstream your changes, or poke me so I can pull them in. Thanks.