563281 - Non-blocking alerts service implementation is dead code

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

dolske points out in bug 563114 (in which he's entirely removing NBAS on 1.9.3) that the only consumer of NBAS is MathML, where it's permanently #if'ed off (since bug 400938, probably) and the only implementor of NBAS is Camino (bug 190307).

This means that unless some insane person is building with ALERT_MISSING_FONTS defined manually, our NBAS impl is dead code on all current branches.  I assume that means we should remove the code?

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(This obviously is one of the build breakages philippe saw building against m-c this weekend.)

Comment 2

[Stuart Morgan]

(In reply to comment #0)
> This means that unless some insane person is building with ALERT_MISSING_FONTS
> defined manually, our NBAS impl is dead code on all current branches.  I assume
> that means we should remove the code?

SGTM

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Removes NonBlockingAlertService implementation

Like so.  Patch applies on cvs trunk (and, with two offsets, on 2_0, for that dead-code removal codesize win! :P ).

Comment 4

[Stuart Morgan]

Comment on attachment 445781 [details] [diff] [review]
Removes NonBlockingAlertService implementation

sr=smorgan. Unship it!

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

CVS trunk, CAMINO_2_0_BRANCH, and http://hg.mozilla.org/camino/rev/c45beca07aba (the latter without the bug number :sigh: )