Closed
Bug 563281
Opened 14 years ago
Closed 14 years ago
Non-blocking alerts service implementation is dead code
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: alqahira)
References
()
Details
(Whiteboard: [camino-2.0.4])
Attachments
(1 file)
5.22 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
dolske points out in bug 563114 (in which he's entirely removing NBAS on 1.9.3) that the only consumer of NBAS is MathML, where it's permanently #if'ed off (since bug 400938, probably) and the only implementor of NBAS is Camino (bug 190307). This means that unless some insane person is building with ALERT_MISSING_FONTS defined manually, our NBAS impl is dead code on all current branches. I assume that means we should remove the code?
Assignee | ||
Comment 1•14 years ago
|
||
(This obviously is one of the build breakages philippe saw building against m-c this weekend.)
Comment 2•14 years ago
|
||
(In reply to comment #0) > This means that unless some insane person is building with ALERT_MISSING_FONTS > defined manually, our NBAS impl is dead code on all current branches. I assume > that means we should remove the code? SGTM
Assignee | ||
Updated•14 years ago
|
Assignee | ||
Comment 3•14 years ago
|
||
Like so. Patch applies on cvs trunk (and, with two offsets, on 2_0, for that dead-code removal codesize win! :P ).
Attachment #445781 -
Flags: superreview?(stuart.morgan+bugzilla)
Comment 4•14 years ago
|
||
Comment on attachment 445781 [details] [diff] [review] Removes NonBlockingAlertService implementation sr=smorgan. Unship it!
Attachment #445781 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Assignee | ||
Comment 5•14 years ago
|
||
CVS trunk, CAMINO_2_0_BRANCH, and http://hg.mozilla.org/camino/rev/c45beca07aba (the latter without the bug number :sigh: )
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.0.4]
You need to log in
before you can comment on or make changes to this bug.
Description
•