Closed Bug 56362 Opened 19 years ago Closed 2 months ago

Will need to clean up ua.css, html.css, and quirk.css (again)

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED INCOMPLETE
mozilla1.0.1

People

(Reporter: ian, Unassigned)

References

(Depends on 2 open bugs)

Details

(5 keywords)

History: As Netscape6 reached RTM, we performed some serious performance work
and general cleanup on the ua.css, quirk.css and html.css files. This gave us
a small performance boost, cut the file in half, and fixed a whole bunch of
lingering bugs that had easy CSS-level fixes. See bug 6625.

We will need to do this again before the next full release, be that mozilla1.0,
NS6.5, or whatever, since the ua.css file quickly accumulates cruft and is not
frequently cleaned up.

The main problem we had when doing this the previous time was that since this
is a very high risk operation (the UA stylesheets affect the entire app!),
there was a chance that the fix would not be accepted that close to release.
However, this change can _only_ happen that close to release, since otherwise
last minute changes are not caught! (To put this in perspective: between the
big changes to the UA stylesheets and the release they was aimed at, at least 4 
checkins happened, and that's with the tight check-in restrictions.)

Therefore, this is an early warning for the next time this has to occur.
Cc'ing interested parties. Please cc everyone who will be affected by this.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
I think every change to ua.css and html.css should be reviewed by Pierre and/or
myself, as Style module owners. Maybe that will help keep the cruft out?

(Same for xul.css --> David Hyatt too, I believe.)
QA Contact: petersen → chrisd
Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...
QA Contact: chrisd → ian
> We will need to do this again before the next full release, be that
> mozilla1.0, NS6.5, or whatever, since the ua.css file quickly
> accumulates cruft and is not frequently cleaned up.

This needs to be done ASAP if it should be ready for Moz1.0. There are all 
sorts of freezes going on ...

Hixie, is there anything worth cleaning up in there? Seems like it has been
pretty stable overt the last 6 months, actually.
Karl: Mozilla 1.0 is not likely to come out any time soon.
Marc: I haven't seen much that needs changing, no. I don't plan on doing this
for Mojo, anyway.
Depends on: 43220
I've spotted 2 things in need of cleanup:

rule for <nobr> in html.css should be moved to quirk.css
rule for blink should be gone; if NS wants to support this for sentimental
reasons in their own build, that's their lookout.
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
this bug hasn't been touched since forever. is there still a
need for this bug to be open?

related bug 84887 bug 5119 bug 15316 bug 16206 bug 33784,
bug 41806 bug 54696 bug 96966 bug 119753 bug 155507 bug 156888

performance related: bug 62892 bug 115429
Assignee: ian → nobody
Status: ASSIGNED → NEW
QA Contact: ian → core.layout
Depends on: 5119, 15316, Default-Quotes, 33784, 84887
No longer depends on: 43220
No longer depends on: 156888

This isn't really actionable. At this point html.css and quirk.css are more or less standardized (modulo quirks we have that are not in the quirks spec) and we have been trying to remove unnecessary stuff from ua.css all along.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.