563669 - Move nsGenericHTMLFormElement::AcceptAutofocus to nsIFormControl

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

At the moment, autofocus is virtual because we can't have a generic |AcceptAutofocus| (or any name) in nsGenericHTMLFormElement because we can't know if the element is an input/button element.
With bug 563668, we could know that so removing this virtual function.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Hmm, I wonder if the patch makes the situation any better.
IIRC I complained about the virtual method because of performance, 
and the new patch uses a virtual method too.

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to comment #2)
> Hmm, I wonder if the patch makes the situation any better.
> IIRC I complained about the virtual method because of performance, 
> and the new patch uses a virtual method too.

Indeed. If you think the patch isn't needed, feel free to cancel the review. We could also consider having |AcceptAutofocus| in |nsGenericHTMLFormElement| is better than having it redefined when it should return PR_TRUE. I've no string opinion about it this...

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

I know it doesn't solve the virtual and perf issue you were pointing but I don't see how to solve it and I think this is at least trying to make things consistent with what bug 641409 is doing.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 519066 [details] [diff] [review]
Patch v2

Update IID.

Comment 6

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/ab37132aaed4