563849 - nsWaveDecoder.cpp: warning C4244: conversion from [TYPE] to [TYPE], possible loss of data

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: fix

{
> nsWaveDecoder.cpp
> content/media/wave/nsWaveDecoder.cpp(588) : warning C4244: 'argument' : conversion from 'double' to 'float', possible loss of data
> content/media/wave/nsWaveDecoder.cpp(607) : warning C4244: 'argument' : conversion from 'double' to 'float', possible loss of data
> content/media/wave/nsWaveDecoder.cpp(648) : warning C4244: 'initializing' : conversion from 'PRInt64' to 'PRUint32', possible loss of data
> content/media/wave/nsWaveDecoder.cpp(950) : warning C4244: 'argument' : conversion from 'PRInt64' to 'PRUint32', possible loss of data
}

The first two are from calls to TimeToBytes, which takes a float, whereas the calls pass in a double.

The third is for the initialization of a PRUint32 value from (an operation involving) the PRInt64 value |got|.

The fourth is for the initialization of a PRUint32 value from (an operation involving) the PRInt64 value |aSize|.

In all cases, I've just made the casts explicit to silence the warnings.

I've also done s/0.0/0.0f/ & s/1.0/1.0f/ for numeric literals that are compared vs. a float variable (otherwise those literals are implicitly treated as doubles), and I've cleaned up a few contextual lines that were > 80 chars.

Comment 1

[Matthew Gregan [:kinetik]]

Comment on attachment 443540 [details] [diff] [review]
fix

Thanks!

Comment 2

[Daniel Holbert [:dholbert]]

Your welcome, thanks for the quick review! Pushed:
http://hg.mozilla.org/mozilla-central/rev/94d4aa4dc42f

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to comment #2)
> Your welcome, thanks for the quick review!

*facepalm* s/Your/You're/