564001 - Should use the first image map in tree order

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Currently we use the map that was first added to the document.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Fix v1

Applies on top of bug 109445.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 444248 [details] [diff] [review]
Fix v1

This leaks the nsContentList if nothing else.

Apart from that, how often do we call this code (looks like at least every paint of an image).  How long does that DOM walk take?  Is it really ok to no longer cache things here?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

This should at least fix the leak. I'm afraid I don't know the answers to your other questions, though.

Comment 4

[Boris Zbarsky [:bzbarsky]]

How about figuring them out?  For the first question, measure or breakpoint in the function and see what the stacks look like.  For the second one, measure.  For the third one, the answer depends on the other two, obviously.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 452547 [details] [diff] [review]
Patch v2

r- pending answers to my questions or some other convincing that the behavior change is ok.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v3

So I never realized that nsContentList is actually live... I guess this should be better.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 458409 [details] [diff] [review]
Patch v3

This looks fine, though a followup to maybe not use the nsIDOMHTML* interface to get the name and id might be good.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks!

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Got some rejects trying to apply this for landing. Also, use 'checkin-needed' to request landing.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I'll refresh when I get approval to get this landed.

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Thanks.

Comment 12

[Jacek Caban]

http://hg.mozilla.org/mozilla-central/rev/7f54a4f3efe8

Comment 13

[Boris Zbarsky [:bzbarsky]]

And http://hg.mozilla.org/mozilla-central/rev/cc10699c5f6a to add the missing test file and fix tree red.

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks.