564026 - [OS/2] still linking problems for shared builds after integration of layers into thebes

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.3a5pre) Gecko/20100505 SeaMonkey/2.1a1pre
Build Identifier: 

Building Seamonkey after checkin for Bug560147
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers17BasicLayerManager16SetDefaultTargetEP10gfxContext'.
weakld: info: The symbol is referenced by:
    E:\mozbuild4\mozilla\widget\src\xpwidgets\xpwidgets_s.lib(nsBaseWidget.o)
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers17BasicLayerManagerC1EP10gfxContext'.
weakld: info: The symbol is referenced by:
    E:\mozbuild4\mozilla\widget\src\xpwidgets\xpwidgets_s.lib(nsBaseWidget.o)
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers15LayerManagerOGL10InitializeEv'.
weakld: info: The symbol is referenced by:
    E:\mozbuild4\mozilla\widget\src\xpwidgets\xpwidgets_s.lib(nsBaseWidget.o)
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers15LayerManagerOGLC1EP9nsIWidget'.
weakld: info: The symbol is referenced by:
    E:\mozbuild4\mozilla\widget\src\xpwidgets\xpwidgets_s.lib(nsBaseWidget.o)
Ignoring unresolved externals reported from weak prelinker.
...
weakld: error: Unresolved symbol (UNDEF) '__ZN7mozilla6layers17BasicLayerManagerC1EP10gfxContext'.
weakld: info: The symbol is referenced by:
    E:\mozbuild4\mozilla\layout\base\gkbase_s.lib(nsDisplayList.o)
    E:\mozbuild4\mozilla\content\html\content\src\gkconhtmlcon_s.lib(nsHTMLMediaElement.o)
Ignoring unresolved externals reported from weak prelinker.

E:\mozbuild4\mozilla\content\html\content\src\gkconhtmlcon_s.lib(nsHTMLMediaElement.o) : error LNK2029: "mozilla::layers::BasicLayerManager::BasicLayerManager(gfxContext*)" : unresolved external
E:\mozbuild4\mozilla\layout\base\gkbase_s.lib(nsDisplayList.o) : error LNK2029: "mozilla::layers::BasicLayerManager::BasicLayerManager(gfxContext*)" : unresolved external

It appears that the BasicLayerManager and LayerManagerOGL symbols are not properly exported, though the respective headers are included in the new file for symbol export gfx/thebes/src/gfxDllDeps.cpp and though the classes are declared as THEBES_API (which should trigger __declspec(dllexport)). The missing symbols are also not in thebes.map

Reproducible: Always

Comment 1

[Walter Meinl]

Attachment: preliminary fix

Probably not what is wanted, but works
I wonder why Windows hasn't the same linking problems

Comment 2

[Bas Schouten (:bas.schouten)]

(In reply to comment #1)
> Created an attachment (id=443720) [details]
> preliminary fix
> 
> Probably not what is wanted, but works
> I wonder why Windows hasn't the same linking problems

I believe in windows we get it with SHARED_LIBRARY_LIBS? Atleast that's what I thought.

Comment 3

[Walter Meinl]

Attachment: add some exports as dummy functions to gfxdlldeps.cpp

similar to the other dlldeps files in the tree (in toolkit/library/ or modules/zlib). Adding dummy functions that are not dllexported by inclusion of the header files to gfxdlldeps exports the missing symbols from thebes.dll. Could ifdef XP_OS2 the added lines if wanted.

Comment 4

[Walter Meinl]

Attachment: updated with comment header for checkin

Comment 5

[Justin Wood (:Callek)]

Pushed as: http://hg.mozilla.org/mozilla-central/rev/9d6f6c45f8de