564098 - [HTML5] "ASSERTION: Script global object not ready"

Status: RESOLVED WORKSFORME

(Core :: DOM: Navigation, defect)

Description

[Jesse Ruderman]

dom/base/crashtests/504224.html triggers:

###!!! ASSERTION: Script global object not ready: 'GetDocument()->GetScriptGlobalObject()', file /home/jruderman/mozilla-central/parser/html/nsHtml5TreeOpExecutor.h, line 144

Comment 1

[Henri Sivonen (:hsivonen)]

The data: URL document never gets its script global object set to a non-null value. (But why?)

Is
var src=document.getElementById('src');
intentional in the test case. There seems to be no element with id 'src'.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Minimized test case

Note: Manually reloading does not trigger this. Reloading from script is needed, curiously.

Comment 3

[Henri Sivonen (:hsivonen)]

Things start going wrong, because
FindContainerView() at
http://mxr-test.konigsberg.mozilla.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#850
returns null, which seems to lead to the script global object of the document not getting set to an inner window object.

Is this expected (and the assertion in the HTML5 parser wrong)? Or is it wrong that a parse can start on a document whose window (iframe) has been detached? It seems kinda scary for the parser to parse into a document (with scripting enabled and all) without the document having an inner window object associated with it.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hmm.  It seems odd that we manage to parse for a document that's detached, yes....  Did that not use to happen with the old parser here?

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to comment #4)
> Hmm.  It seems odd that we manage to parse for a document that's detached,
> yes....  Did that not use to happen with the old parser here?

It happens with the old parser, too. We just don't have an assert in the old parser in the tree.

Based on that, moving this out of the Parser component to Document Navigation.

Comment 6

[Henri Sivonen (:hsivonen)]

See also the #whatwg IRC log from 
http://krijnhoetmer.nl/irc-logs/whatwg/20100720#l-624
to about the end of that day's log.

Comment 7

[Jesse Ruderman]

Still happens after a recent change to the assertion (in bug 651072).

###!!! ASSERTION: Script global object not ready: '!mDocShell || GetDocument()->GetScriptGlobalObject()', file /builds/slave/m-cen-osx64-dbg/build/parser/html/nsHtml5TreeOpExecutor.h, line 157

Comment 8

[Jesse Ruderman]

WFM. Maybe fixed by bug 717488?