Closed
Bug 564158
Opened 14 years ago
Closed 14 years ago
mozalloc_abort and nsDebugImpl:Abort don't trigger Breakpad on OS X?
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: ted, Assigned: cjones)
References
Details
Attachments
(2 files)
|
59.16 KB,
text/plain
|
Details | |
|
3.09 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
I hit an OOM crash via mozalloc on OS X, and I got the Apple Crash Reporter, not Breakpad. This is bad. Looks like you're using abort(), which I would have thought would work, but maybe not. Maybe you just need to dereference NULL or something instead. :-/ (Alternately, you could build on the APIs added for generating minidumps for hangs and write a minidump and exit().)
|
Assignee | |
Comment 1•14 years ago
|
||
Hum. This code was lifted directly from nsDebugImpl::Abort, but with s/PR_Abort/abort/, so ABORT_IF_FALSE() and RUNTIMEABORT() should be broken as well. That's annoying.
Summary: mozalloc_handle_oom doesn't trigger Breakpad on OS X? → mozalloc_abort and nsDebugImpl:Abort don't trigger Breakpad on OS X?
|
|
Assignee | |
Comment 2•14 years ago
|
||
Assignee: nobody → jones.chris.g
Attachment #443924 -
Flags: review?(ted.mielczarek)
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 443924 [details] [diff] [review]
Centralize the breakpad-triggering abort code in mozalloc and use |*NULL| to abort on mac, since abort() doesn't trigger breakpad
About as sane as this code can be.
Attachment #443924 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/09db4a9612ae (got the bug # wrong, oops)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
You need to log in
before you can comment on or make changes to this bug.
Description
•