mozalloc_abort and nsDebugImpl:Abort don't trigger Breakpad on OS X?

RESOLVED FIXED

Status

()

Core
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: ted, Assigned: cjones)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(blocking2.0 final+)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
Created attachment 443863 [details]
Apple crash report

I hit an OOM crash via mozalloc on OS X, and I got the Apple Crash Reporter, not Breakpad. This is bad. Looks like you're using abort(), which I would have thought would work, but maybe not. Maybe you just need to dereference NULL or something instead. :-/ (Alternately, you could build on the APIs added for generating minidumps for hangs and write a minidump and exit().)
Hum.  This code was lifted directly from nsDebugImpl::Abort, but with s/PR_Abort/abort/, so ABORT_IF_FALSE() and RUNTIMEABORT() should be broken as well.  That's annoying.
Summary: mozalloc_handle_oom doesn't trigger Breakpad on OS X? → mozalloc_abort and nsDebugImpl:Abort don't trigger Breakpad on OS X?
Created attachment 443924 [details] [diff] [review]
Centralize the breakpad-triggering abort code in mozalloc and use |*NULL| to abort on mac, since abort() doesn't trigger breakpad
Assignee: nobody → jones.chris.g
Attachment #443924 - Flags: review?(ted.mielczarek)
(Reporter)

Comment 3

8 years ago
Comment on attachment 443924 [details] [diff] [review]
Centralize the breakpad-triggering abort code in mozalloc and use |*NULL| to abort on mac, since abort() doesn't trigger breakpad

About as sane as this code can be.
Attachment #443924 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/09db4a9612ae (got the bug # wrong, oops)
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
blocking2.0: ? → final+
You need to log in before you can comment on or make changes to this bug.