564187 - "Tabs on Top" shouldn't put tabs above the menu bar

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Ideally this will be user customizable, but this is correct default behavior.

Comment 2

[Peter Henkel [:Terepin]]

A if tabs will be in title bar, then what? You will put them back to tab bar and above that you will put menu bar? That seems wrong to me.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>A if tabs will be in title bar, then what?

Then it would also be up to the user to decide where they want to place the
menu bar (or if they want to use one).

Comment 4

[Peter Henkel [:Terepin]]

Then it is OK.

Comment 5

[Jim Jeffery not reading bug-mail 1/2/11]

Huh ?  I thought the Menu Bar was going away in favor of the Firefox or 'application' button ?

Comment 6

[Peter Henkel [:Terepin]]

No. Menu bar will be off by default, but it will be still there for users who want to bring it back, temporarily or permanently.

Comment 7

[Ria Klaassen (not reading all bugmail)]

Really? I don't use the feature but I would expect them quite on top, as an easier target for the mouse. On top = on top.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 443880 [details] [diff] [review]
patch

>diff --git a/browser/base/content/browser.css b/browser/base/content/browser.css

>+#toolbar-menubar {
>+  -moz-box-ordinal-group: 5;
>+}
>+
>+#navigator-toolbox > toolbar:not(#toolbar-menubar):not(#TabsToolbar) {
>   -moz-box-ordinal-group: 50;
> }
> 
> #TabsToolbar {
>   -moz-box-ordinal-group: 100;
> }
> 
> #navigator-toolbox[tabsontop="true"] > #TabsToolbar {

I think this order would be clearer:
#toolbar-menubar {}
#navigator-toolbox[tabsontop="true"] > #TabsToolbar {}
#navigator-toolbox > toolbar:not(#toolbar-menubar):not(#TabsToolbar) {}
#TabsToolbar {}

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #8)
> I think this order would be clearer:
> #toolbar-menubar {}
> #navigator-toolbox[tabsontop="true"] > #TabsToolbar {}
> #navigator-toolbox > toolbar:not(#toolbar-menubar):not(#TabsToolbar) {}
> #TabsToolbar {}

The second selector overrides the fourth one, reflecting that in the order seems clearer to me.

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/ade46e1e12ec