Closed Bug 564187 Opened 10 years ago Closed 10 years ago

"Tabs on Top" shouldn't put tabs above the menu bar

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.7a5

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #443880 - Flags: ui-review?(faaborg)
Attachment #443880 - Flags: review?(gavin.sharp)
Attachment #443880 - Flags: ui-review?(faaborg) → ui-review+
Ideally this will be user customizable, but this is correct default behavior.
A if tabs will be in title bar, then what? You will put them back to tab bar and above that you will put menu bar? That seems wrong to me.
>A if tabs will be in title bar, then what?

Then it would also be up to the user to decide where they want to place the
menu bar (or if they want to use one).
Then it is OK.
Huh ?  I thought the Menu Bar was going away in favor of the Firefox or 'application' button ?
No. Menu bar will be off by default, but it will be still there for users who want to bring it back, temporarily or permanently.
Really? I don't use the feature but I would expect them quite on top, as an easier target for the mouse. On top = on top.
Comment on attachment 443880 [details] [diff] [review]
patch

>diff --git a/browser/base/content/browser.css b/browser/base/content/browser.css

>+#toolbar-menubar {
>+  -moz-box-ordinal-group: 5;
>+}
>+
>+#navigator-toolbox > toolbar:not(#toolbar-menubar):not(#TabsToolbar) {
>   -moz-box-ordinal-group: 50;
> }
> 
> #TabsToolbar {
>   -moz-box-ordinal-group: 100;
> }
> 
> #navigator-toolbox[tabsontop="true"] > #TabsToolbar {

I think this order would be clearer:
#toolbar-menubar {}
#navigator-toolbox[tabsontop="true"] > #TabsToolbar {}
#navigator-toolbox > toolbar:not(#toolbar-menubar):not(#TabsToolbar) {}
#TabsToolbar {}
Attachment #443880 - Flags: review?(gavin.sharp) → review+
(In reply to comment #8)
> I think this order would be clearer:
> #toolbar-menubar {}
> #navigator-toolbox[tabsontop="true"] > #TabsToolbar {}
> #navigator-toolbox > toolbar:not(#toolbar-menubar):not(#TabsToolbar) {}
> #TabsToolbar {}

The second selector overrides the fourth one, reflecting that in the order seems clearer to me.
http://hg.mozilla.org/mozilla-central/rev/ade46e1e12ec
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
Blocks: 590847
You need to log in before you can comment on or make changes to this bug.