Closed Bug 564261 Opened 12 years ago Closed 12 years ago

mozalloc.h:56:1: warning: C++ style comments are not allowed in ISO C90

Categories

(Core :: XPCOM, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

References

()

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

{
> In file included from ../../../mozilla/xpcom/build/../base/nscore.h:50,
>                  from ../../../mozilla/xpcom/build/../glue/pldhash.h:45,
>                  from pldhash.c:49:
> ../../dist/include/mozilla/mozalloc.h:56:1: warning: C++ style comments are not allowed in ISO C90
> ../../dist/include/mozilla/mozalloc.h:56:1: warning: (this will be reported only once per input file)
}

There are just 2 lines of C++ style comments, added in this changeset:
http://hg.mozilla.org/mozilla-central/diff/bbbb2d668d0d/memory/mozalloc/mozalloc.h

Patch coming up.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Attachment #443922 - Flags: review?(jones.chris.g)
(In reply to comment #0)
> >                  from pldhash.c:49:
FWIW, we also hit this warning when building gtk2xtbin.c and gtk2drawing.c.
Comment on attachment 443922 [details] [diff] [review]
fix

Heh, oops.
Attachment #443922 - Flags: review?(jones.chris.g) → review+
http://hg.mozilla.org/mozilla-central/rev/30afcda0bec7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.