Closed
Bug 564319
Opened 15 years ago
Closed 15 years ago
Allow building ctypes on Android
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mwu, Assigned: mwu)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.08 KB,
patch
|
Details | Diff | Splinter Review |
Another vlad patch from mozilla-droid. Not sure if there's a better way of doing this.
Attachment #443984 -
Flags: review?(ted.mielczarek)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 443984 [details] [diff] [review]
Allow building ctypes on Android
Is there a reason you can't just do the export bit? Do those variables get munged along the way in some manner?
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 443984 [details] [diff] [review]
Allow building ctypes on Android
vlad says some things get munged along the way (like CFLAGS/CXXFLAGS). I don't think CC/CXX/LD should get changed though, so could you drop the ANDROID_ variables of those (or prove me wrong)?
r=me with that change
Attachment #443984 -
Flags: review?(ted.mielczarek) → review+
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #443984 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•