Closed Bug 564365 Opened 14 years ago Closed 14 years ago

canceling setup, then setting up Weave, doesn't set firstrun pref, causing problems later.

Categories

(Firefox :: Sync, defect)

x86
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: tchung, Assigned: mconnor)

References

Details

(Whiteboard: [weave1.3])

Attachments

(1 file)

When opening a new browser window, it will always fire up the Weave setup dialog.  This is only if you are not logged into weave.

Repro:
1) install weave 1.3b4
2) do not setup your weave account
3) open a new window (CTRL-N, CMD-N)
4) Verify the Weave setup modal dialog box fires up into the foreground also

Expected:
- I do not want to see the weave modal dialog box unless i open it on my own command

Actual:
- Weave dialog pop fires up each time a new browser window is opened
Flags: blocking-weave1.3?
Whiteboard: [weave1.3]
Component: Fennec UI → Firefox UI
QA Contact: fennec → firefox
hmm, this is a bigger problem than i thought.   Do the steps above, but *DO* log in.  Open a new window, and not only does the popup setup dialog appear, but your existing account gets signed out.   status bar reverts to "set up Weave..."

We can't be signing people out each time they open a new browser window
Severity: normal → critical
Summary: opening a new browser window pops up the Weave setup dialog → opening a new browser window pops up the Weave setup dialog and logs you out
Assignee: nobody → mconnor
Severity: critical → major
Flags: blocking-weave1.3? → blocking-weave1.3+
Summary: opening a new browser window pops up the Weave setup dialog and logs you out → canceling setup, then setting up Weave, doesn't set firstrun pref, causing problems later.
Flagging in-litmus?.  this could use a litmus testcase for this area
Flags: in-litmus?
Attached patch v1Splinter Review
Attachment #444115 - Flags: review?(edilee)
Target Milestone: --- → 1.3b5
Attachment #444115 - Flags: review?(edilee) → review+
http://hg.mozilla.org/labs/weave/rev/db2600e7153b
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
setup has been moved into prefs panel in-litmus-
Flags: in-litmus? → in-litmus-
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: