Closed
Bug 564414
Opened 14 years ago
Closed 14 years ago
XP_MACOSX is not defined on Mac
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
3.04 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Currently the JS build system does not define XP_MACOSX when building on MACOSX meaning that few mac-specific optimizations are not picked up.
|
Assignee | |
Comment 1•14 years ago
|
||
This is what I have submitted to the try server.
|
|
Assignee | |
Comment 2•14 years ago
|
||
Try server revealed that some code got rotten and the v2 fixes compilation errors and warnings comming from defining XP_MACOSX
Attachment #444073 -
Attachment is obsolete: true
Attachment #444245 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Ted: This patch blocks the bug 516832, beta1 blocker. So could you review the patch quickly?
|
||
Updated•14 years ago
|
Attachment #444245 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/331f0bb3bbd6
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/331f0bb3bbd6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•