Closed
Bug 564523
Opened 14 years ago
Closed 14 years ago
passphrase can match password for new accounts
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
1.3b5
People
(Reporter: mconnor, Assigned: mconnor)
References
Details
Attachments
(1 file)
4.64 KB,
patch
|
Mardak
:
review+
|
Details | Diff | Splinter Review |
fallout from unification. this is kind of a hacky solution, I'll think about a more elegant solution later.
Flags: blocking-weave1.3+
Attachment #444182 -
Flags: review?
Updated•14 years ago
|
Attachment #444182 -
Attachment is patch: true
Attachment #444182 -
Attachment mime type: application/octet-stream → text/plain
Attachment #444182 -
Flags: review? → review?(edilee)
Comment 1•14 years ago
|
||
Comment on attachment 444182 [details] [diff] [review] kind of a hack >+++ b/source/chrome/locale/en-US/errors.properties > change.passphrase.ppSameAsPassphrase = The secret phrase cannot be the same as your current secret phrase > change.passphrase.ppSameAsPassword = The secret phrase cannot be the same as your password >+change.passphrase.ppSameAsUsername = The secret phrase cannot be the same as your user name >+change.password.pwSameAsPassphrase = Password can't match secret phrase >+change.password.pwSameAsPassword = Password can't match current password >+change.password.pwSameAsUsername = Password can't match your user name Any reason why we have different wording for passphrase vs password matching/being same?
Attachment #444182 -
Flags: review?(edilee) → review+
Assignee | ||
Comment 2•14 years ago
|
||
There's more room in the secret phrase UIs for longer strings. The password fields are in grids which eat a lot of space, so we'd get ugly UI with longer strings. I'm probably going to file a bug on doing feedback using an XBL binding so we can play with using description or something similar to allow wrapping, without putting a lot of intelligence into callers. Also means language with longer strings aren't as screwed.
Comment 3•14 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/dd38e2a22bc0
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Flags: in-testsuite?
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•