564523 - passphrase can match password for new accounts

Status: RESOLVED FIXED

Description

[Mike Connor [:mconnor]]

Created attachment 444182 [details] [diff] [review]
kind of a hack

fallout from unification.  this is kind of a hacky solution, I'll think about a more elegant solution later.

Comment 1

[Ed Lee :Mardak (PTO Oct 27 - Nov 18)]

Comment on attachment 444182 [details] [diff] [review]
kind of a hack

>+++ b/source/chrome/locale/en-US/errors.properties
> change.passphrase.ppSameAsPassphrase = The secret phrase cannot be the same as your current secret phrase
> change.passphrase.ppSameAsPassword   = The secret phrase cannot be the same as your password
>+change.passphrase.ppSameAsUsername   = The secret phrase cannot be the same as your user name
>+change.password.pwSameAsPassphrase   = Password can't match secret phrase
>+change.password.pwSameAsPassword     = Password can't match current password
>+change.password.pwSameAsUsername     = Password can't match your user name
Any reason why we have different wording for passphrase vs password matching/being same?

Comment 2

[Mike Connor [:mconnor]]

There's more room in the secret phrase UIs for longer strings.  The password fields are in grids which eat a lot of space, so we'd get ugly UI with longer strings.

I'm probably going to file a bug on doing feedback using an XBL binding so we can play with using description or something similar to allow wrapping, without putting a lot of intelligence into callers.  Also means language with longer strings aren't as screwed.

Comment 3

[Ed Lee :Mardak (PTO Oct 27 - Nov 18)]

http://hg.mozilla.org/labs/weave/rev/dd38e2a22bc0