Closed Bug 564569 Opened 10 years ago Closed 10 years ago

[FIX]Speed up the cache-hit case of getElementsBy(Class)Name

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

Right now we do the work of parsing the class list or allocating a copy of the name string even for the cache hit case.  There's no need to do that; in fact there's really no need to ever heap-allocate the name string.  Patch coming up.
Blocks: domperf
Actually, I'm going to rebase that to be on top of bug 560462, which I hope will land real soon here.
Attached patch Like so (obsolete) — Splinter Review
Attachment #444226 - Attachment is obsolete: true
Attachment #444230 - Flags: review?(jst)
Attachment #444226 - Flags: review?(jst)
Attached patch And let's not forget to qref.... (obsolete) — Splinter Review
Attachment #444230 - Attachment is obsolete: true
Attachment #444231 - Flags: review?(jst)
Attachment #444230 - Flags: review?(jst)
Attachment #444231 - Attachment is obsolete: true
Attachment #444417 - Flags: review?(jst)
Attachment #444231 - Flags: review?(jst)
Comment on attachment 444417 [details] [diff] [review]
One more tweak to make stuff even faster

Nice!
Attachment #444417 - Flags: review?(jst) → review+
Depends on: 560462
Pushed http://hg.mozilla.org/mozilla-central/rev/6fce6521907a
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.