Closed
Bug 564569
Opened 15 years ago
Closed 15 years ago
[FIX]Speed up the cache-hit case of getElementsBy(Class)Name
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
|
11.28 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
Right now we do the work of parsing the class list or allocating a copy of the name string even for the cache hit case. There's no need to do that; in fact there's really no need to ever heap-allocate the name string. Patch coming up.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #444226 -
Flags: review?(jst)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Actually, I'm going to rebase that to be on top of bug 560462, which I hope will land real soon here.
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #444226 -
Attachment is obsolete: true
Attachment #444230 -
Flags: review?(jst)
Attachment #444226 -
Flags: review?(jst)
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #444230 -
Attachment is obsolete: true
Attachment #444231 -
Flags: review?(jst)
Attachment #444230 -
Flags: review?(jst)
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #444231 -
Attachment is obsolete: true
Attachment #444417 -
Flags: review?(jst)
Attachment #444231 -
Flags: review?(jst)
|
||
Comment 6•15 years ago
|
||
Comment on attachment 444417 [details] [diff] [review]
One more tweak to make stuff even faster
Nice!
Attachment #444417 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 7•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•