[FIX]Pass the first appended node to ContentAppended

RESOLVED FIXED in mozilla1.9.3a5

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9.3a5
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Callees can get it now using the index, but we'd like to remove the index.  This bug is just about passing the node; updating callees to not use the index should happen in separate bugs.
(Assignee)

Comment 1

9 years ago
Created attachment 444232 [details] [diff] [review]
Like so
Attachment #444232 - Flags: superreview?(jonas)
Attachment #444232 - Flags: review?(jst)
Comment on attachment 444232 [details] [diff] [review]
Like so

- In nsXULDocument::ContentAppended():

     // Update our element map
     PRUint32 count = aContainer->GetChildCount();

Looks like count is unused after this change. 

- In layout/svg/base/src/nsSVGEffects.cpp:

 nsSVGRenderingObserver::ContentAppended(nsIDocument *aDocument,
                                         nsIContent *aContainer,
-                                        PRInt32 aNewIndexInContainer)
+					nsIContent *aFirstNewContent,

Remove the tabs that crept in here somehow...

- In parser/html/nsHtml5PendingNotification.h:

     inline void Fire() {
-      nsNodeUtils::ContentAppended(mParent, mChildCount);
+      nsNodeUtils::ContentAppended(mParent, mParent->GetChildAt(mChildCount),
+				   mChildCount);

More tabs...

r=jst with those minor issues fixed.
Attachment #444232 - Flags: review?(jst) → review+
Comment on attachment 444232 [details] [diff] [review]
Like so

There are tabs in the new code in sSVGRenderingObserver::ContentAppended

sr=me with that fixed
Attachment #444232 - Flags: superreview?(jonas) → superreview+
(Assignee)

Comment 4

9 years ago
Pushed http://hg.mozilla.org/mozilla-central/rev/3da93d131e35 with those changes.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Depends on: 564974
(Assignee)

Updated

9 years ago
No longer depends on: 564974
(Assignee)

Updated

9 years ago
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.