564574 - [FIX]Pass the first appended node to ContentAppended

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Callees can get it now using the index, but we'd like to remove the index.  This bug is just about passing the node; updating callees to not use the index should happen in separate bugs.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 444232 [details] [diff] [review]
Like so

- In nsXULDocument::ContentAppended():

     // Update our element map
     PRUint32 count = aContainer->GetChildCount();

Looks like count is unused after this change. 

- In layout/svg/base/src/nsSVGEffects.cpp:

 nsSVGRenderingObserver::ContentAppended(nsIDocument *aDocument,
                                         nsIContent *aContainer,
-                                        PRInt32 aNewIndexInContainer)
+					nsIContent *aFirstNewContent,

Remove the tabs that crept in here somehow...

- In parser/html/nsHtml5PendingNotification.h:

     inline void Fire() {
-      nsNodeUtils::ContentAppended(mParent, mChildCount);
+      nsNodeUtils::ContentAppended(mParent, mParent->GetChildAt(mChildCount),
+				   mChildCount);

More tabs...

r=jst with those minor issues fixed.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 444232 [details] [diff] [review]
Like so

There are tabs in the new code in sSVGRenderingObserver::ContentAppended

sr=me with that fixed

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/3da93d131e35 with those changes.