Closed Bug 564585 Opened 11 years ago Closed 11 years ago

Use WrapNativeParent if we can in nsNodeSH::PreCreate

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b3

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file, 1 obsolete file)

We call WrapNative at the end of nsNodeSH::PreCreate because if the node that's being wrapped is a document node we use the document's scope object which doesn't have a wrapper cache. We could instead call WrapNative at that point, and use WrapNativeParent for all other cases.
Attached patch v1 (obsolete) — Splinter Review
This applies on top of part 2 of the patches in bug 564266.
Attached patch v1Splinter Review
Attachment #451973 - Attachment is obsolete: true
Attachment #455519 - Flags: review?(bzbarsky)
Comment on attachment 455519 [details] [diff] [review]
v1

r=bzbarsky
Attachment #455519 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/8951841a4cda
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.