564950 - Make more use of mozilla::services

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mitchell Field [:Mitch]]

We should replace more do_GetService() calls with mozilla::services::Get*Service(), as was done in bug 560095 (which itself stems from bug 516085).

Comment 1

[Mitchell Field [:Mitch]]

Attachment: Patch v1

This patch touches several modules and passes TryServer. Appropriate peers/owners should state which part(s) they're reviewing.

Comment 2

[Josh Aas]

Comment on attachment 444539 [details] [diff] [review]
Patch v1

+    nsCOMPtr<nsIStringBundleService> strings =
+      mozilla::services::GetStringBundleService();
+    if (!strings)
+      NS_ERROR_FAILURE;

Missing "return".

Comment 3

[Mitchell Field [:Mitch]]

Attachment: Patch v1.1

Fixed.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Could you break it up so that people know which part they're supposed to review?

Comment 5

[Mitchell Field [:Mitch]]

Attachment: accessible

Comment 6

[Mitchell Field [:Mitch]]

Attachment: caps

Comment 7

[Mitchell Field [:Mitch]]

Attachment: content

Comment 8

[Mitchell Field [:Mitch]]

Attachment: docshell

Comment 9

[Mitchell Field [:Mitch]]

Attachment: dom

Comment 10

[Mitchell Field [:Mitch]]

Attachment: editor

Comment 11

[Mitchell Field [:Mitch]]

Attachment: intl

Comment 12

[Mitchell Field [:Mitch]]

Attachment: layout

Comment 13

[Mitchell Field [:Mitch]]

Attachment: modules

Comment 14

[Mitchell Field [:Mitch]]

Attachment: parser

Comment 15

[Mitchell Field [:Mitch]]

Attachment: toolkit

Comment 16

[Mitchell Field [:Mitch]]

Attachment: widget

Comment 17

[Mitchell Field [:Mitch]]

Attachment: xpcom

Comment 18

[Mitchell Field [:Mitch]]

Attachment: xpfe

Comment 19

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 444568 [details] [diff] [review]
layout

thanks!

Comment 20

[Mike Shaver (:shaver emeritus)]

Comment on attachment 444573 [details] [diff] [review]
xpcom

TBH, I think that we should just crash if we're in the middle of running the app and can't get a key service, but that's a battle for clarity and minimalism that I'll fight in another context!

Comment 21

[Mitchell Field [:Mitch]]

Attachment: [for-checkin] patch

Thanks for the reviews. This amalgamation is ready for check-in. Patch includes Hg changeset summary.

Comment 22

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/840fcbf52747