Closed
Bug 564979
Opened 15 years ago
Closed 14 years ago
[FIX]Get rid of nsINode::GetSibling
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
5.31 KB,
patch
|
peterv
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
We can use GetNextSibling/GetPreviousSibling now.
|
Assignee | |
Updated•15 years ago
|
|
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #444590 -
Flags: superreview?(jonas)
Attachment #444590 -
Flags: review?(peterv)
|
||
Updated•15 years ago
|
Attachment #444590 -
Flags: review?(peterv) → review+
Attachment #444590 -
Flags: superreview?(jonas) → superreview+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
|
Assignee | |
Comment 3•14 years ago
|
||
And backed out: http://hg.mozilla.org/mozilla-central/rev/c95e1d49bc79
The problem is that GetFirstChild is broken (and always has been!) for attribute nodes.
|
|
Assignee | |
Updated•14 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 4•14 years ago
|
||
> (and always has been!)
No, I lied. It broke with bug 564432 part 2.
|
|
Assignee | |
Comment 5•14 years ago
|
||
I filed bug 566416 on fixing GetFirstChild. That needs to be fixed before this can land.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•14 years ago
|
||
Either this or bug 566416 gave us:
Improvement: Dromaeo (DOM) increase 3.27% on MacOSX 10.5.8 Firefox
Improvement: Dromaeo (DOM) increase 1.53% on Linux x64 Firefox
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•