buildbot should cope when firefox/plugins doesn't exist

RESOLVED FIXED

Status

Release Engineering
Other
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: Josh Aas, Unassigned)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
I checked in a patch for bug 533891, which passed locally, on the try servers and also on the production servers. Later on a clobber happened and my patch was found to have caused a problem:

====================
bash -c cp bin/xpcshell firefox && cp -R bin/components/* firefox/components/
&& cp -R bin/plugins/* firefox/plugins/ && python -u
xpcshell/runxpcshelltests.py --symbols-path=symbols
--manifest=xpcshell/tests/all-test-dirs.list firefox/xpcshell
cp: cannot create regular file `firefox/plugins/': Is a directory
====================

This seems to be related to this code:

http://mxr.mozilla.org/build/source/buildbotcustom/steps/unittest.py#452

I'm not sure exactly what is wrong but this problem needs to be resolved one way or another.
I'm not positive, but I think what's wrong is that since we're still going to
scan firefox/plugins/, and tests need to have the test plugin in there, but
we're not going to ship anything in there anymore, unittest.py (and every lame
plugin installer that thinks dropping crud in there is the right thing to do)
needs to create the directory if it doesn't exist, before copying into it.
Assignee: build → nobody
Component: Tinderbox Configuration → Release Engineering
QA Contact: ccooper → release
The "copy crap to the app dir" is because we haven't yet fixed bug 486570.
(Reporter)

Updated

7 years ago
Depends on: 486570
To be crystal clear, the work item is: Ensure firefox/plugins exists before trying to copy to it.
Summary: problem with assumptions about the existence of a plugins dir → buildbot should cope when firefox/plugins doesn't exist
Created attachment 444738 [details] [diff] [review]
untested solution
Attachment #444738 - Flags: review?(catlee)
(Reporter)

Comment 5

7 years ago
I have tested Flash, Quicktime, and WMP installers on Windows 7 - none of them have problems with Firefox not having a plugins dir in the app package. The WMP installer creates the dir, the others just use the registry as they should.
Josh, if QuickTime is using the registry then that is new. My Win7 system has QuickTime installed and it doesn't though it has copied several QuickTime plugin files into my plugins directory... can you double check this?
(Reporter)

Comment 7

7 years ago
I had Quicktime in the plugins dir too (when I had one), I think quicktime is just playing it safe and using the registry + the plugins dir if one exists. We aren't deleting the plugins dir, so if someone had one from an older quicktime install that didn't use the registry (I don't know if such a thing exists) they'll be fine.

Updated

7 years ago
Attachment #444738 - Flags: review?(catlee) → review+
Comment on attachment 444738 [details] [diff] [review]
untested solution

changeset:   723:c7a0781ae36f
Attachment #444738 - Flags: checked-in+
tm02 has been restarted.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.