56507 - Color problem with Classic Skin and GTK Themes

Status: VERIFIED DUPLICATE of bug 57429

(SeaMonkey :: Themes, defect, P3)

Description

[Nick Pilon]

I've run into a rather nasty problem with the classic theme and some GTK skins.
The preferences dialog fonts seem to change color according to user preferences
just fine, but the list box backgrounds don't. If your theme happens to set the
default foreground color to white, this makes the preferences stuff pretty much
unusable. The browser fonts in this skin also look abnormally large, but I'm not
sure if this is a related problem or a preferences setting.

Comment 1

[Decklin Foster]

Screenshot please? (preferably with a GTK app alongside) Also, what build id?

"list boxes" sounds like something that should be using -moz-field (bug 53723).
If you can point out someplace where the background is incorrectly hardcoded as
white, it should be easy to make a patch.

The font issue is definetly unrelated, check your DPI prefs and search for the
bugs filed on it.

Comment 2

[Nick Pilon]

Attachment: The GNOME control center showing the GTK theme selector. Notice the white FG text and gray-ish backgrounds.

Comment 3

[Nick Pilon]

Attachment: Mozilla preferences. Note the white foreground text used and the unchanged white background.

Comment 4

[Nick Pilon]

I've attached a couple of images (there's some corruption in one of them on my
display, but not when I try to view the file locally... Not sure what caused
that) to show what I mean. If these aren't quite enough, I can provide more.

Comment 5

[Decklin Foster]

Attachment: Patch to fix it

Comment 6

[Decklin Foster]

The above patch corrects a bunch of places that had #FFFFFF or #000000 instead
of CSS2 colors, and fixes it here. Since this is classic, sending over to Ben
for a look.

Comment 7

[Decklin Foster]

*** Bug 59562 has been marked as a duplicate of this bug. ***

Comment 8

[Vesa Halttunen]

The attached patch works just fine and shouldn't break anything when applied
correctly. Ready for the trunk IMO.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Given the advent of -moz-field, which came after the addition of unix specific 
stylesheets for areas where 'Window' being grey screwed up textfields, I would 
suggest the unix versions of these sheets just be trashed and they use the 
windows ones again. 

Comment 10

[Vesa Halttunen]

It seems that the UNIX versions of the sheets are gone (or at least I can't find
any reference to "unix" anywhere in the classic chrome directory) but the sheets
are still using direct color definitions (#FFFFFF) instead of -moz-field (Linux
build 2001010512). 

Comment 11

[Joe Hewitt (gone)]

duplicate

*** This bug has been marked as a duplicate of 57429 ***

Comment 12

[Diego]

Verified dupe of bug 57429: "Win classic theme should support system colors"