565186 - WARNING: NS_ENSURE_TRUE(mDocument && mDocShell) failed: file nsHtml5TreeOpExecutor.cpp

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I see excessive numbers of:

WARNING: NS_ENSURE_TRUE(mDocument && mDocShell) failed: file .../mozilla/parser/html/nsHtml5TreeOpExecutor.cpp, line 610

on many sites.  (One example is http://maps.google.com/, but I've seen other sites with significantly larger numbers.)


Should this actually spam the console every time it happens?  Is there something going wrong?

Comment 1

[Henri Sivonen (:hsivonen)]

The code is question is legacy code copied from elsewhere in Gecko (from nsHTMLContentSink.cpp), which is why it uses NS_ENSURE_TRUE, which in turn spams the console pointlessly.

The new parser calls this code where the old parser didn't (in innerHTML setter), because there's no normal sink / fragment sink distinction. Changing this is bug 559319.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: get rid of NS_ENSURE_TRUE

If the spam is pointless, can we just remove it, like so?

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/3a48588b558b

Thanks!