Closed Bug 565187 Opened 10 years ago Closed 10 years ago

Need icons for new geolocation notification

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b2

People

(Reporter: Gavin, Assigned: shorlander)

References

Details

(Whiteboard: popupnotification)

Attachments

(3 files, 2 obsolete files)

Alex's mockups include a largish globe-like icon for the notification itself, and a smaller reticle-like icon for the location bar.
This is the icon that I have used in my themes.
Source:
http://kurage.kilo.jp/

Another good source of a world image is:
http://commons.wikimedia.org/wiki/File:Erioll_world_2.svg

And a rotating one:
http://gaialab.asu.edu/Jordan/
This patch adds new notification icons for geolocation.

- Adds 64x64 geolocation panel icons for Windows, Mac and Linux
- New location bar glyph for Windows, Mac and Linux
- Removes the old Geo.png
- Match the -16, -64 naming convention
- Fixes the margin issue on OS X
Attachment #455049 - Flags: review?(dao)
Whiteboard: popupnotification
Comment on attachment 455049 [details] [diff] [review]
Patch for New Geolocation Notifications Icons

>+#geolocation {
>+  margin-left: -27px;
>+}

What's this?

We usually try to avoid globes with real land masses, and the crosshairs on the US seems particularly bad... Can we use the Firefox globe for this?
(In reply to comment #4)
> (From update of attachment 455049 [details] [diff] [review])
> >+#geolocation {
> >+  margin-left: -27px;
> >+}
> 
> What's this?

To fix the huge left margin caused by using border image for the panels.


> We usually try to avoid globes with real land masses, and the crosshairs on the
> US seems particularly bad... Can we use the Firefox globe for this?

They are actually not real continents beyond a general location similarity that just happened to work out better in the composition.

Thanks!
(In reply to comment #5)
> > >+#geolocation {
> > >+  margin-left: -27px;
> > >+}
> > 
> > What's this?
> 
> To fix the huge left margin caused by using border image for the panels.

We need a more generic solution to this, as the same panel style is going to be used for other notifications. I'd prefer this to be taken care of in a separate bug.

> > We usually try to avoid globes with real land masses, and the crosshairs on the
> > US seems particularly bad... Can we use the Firefox globe for this?
> 
> They are actually not real continents beyond a general location similarity that
> just happened to work out better in the composition.

Even at a second and third glance I still seem to recognize North and South America. It's an icon, so it doesn't really matter that the borders aren't quite accurate, the rough shape counts.
(In reply to comment #6)
> We need a more generic solution to this, as the same panel style is going to be
> used for other notifications. I'd prefer this to be taken care of in a separate
> bug.

Yeah I agree. Removed.

> Even at a second and third glance I still seem to recognize North and South
> America. It's an icon, so it doesn't really matter that the borders aren't
> quite accurate, the rough shape counts.

I tweaked them a little to try and mitigate that but in general I don't feel it is a problem and I feel comfortable with them as they are.

Thanks! :)
Attachment #455049 - Attachment is obsolete: true
Attachment #455049 - Flags: review?(dao)
Attachment #455316 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/ffedf4255772
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7b2
Blocks: 573588
No longer blocks: 573588
Blocks: 573588
No longer blocks: 573588
Depends on: 581193
Duplicate of this bug: 601241
No longer depends on: 581193
You need to log in before you can comment on or make changes to this bug.