565199 - TM: trace-test failure in testGeneratorDeepBail, x64

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Maybe missing guard for generators?

#2  0x000000000048b1a2 in js_CloseIterator (cx=0x8bd430, v=140737332126848) at ../jsiter.cpp:594
594	        JS_ASSERT_NOT_ON_TRACE(cx);


rogram received signal SIGABRT, Aborted.
0x00007ffff7bcf7bb in raise () from /lib/libpthread.so.0
(gdb) bt
#0  0x00007ffff7bcf7bb in raise () from /lib/libpthread.so.0
#1  0x0000000000527a2c in JS_Assert (s=0x5f069f "!JS_ON_TRACE(cx)", file=0x5f0577 "../jsiter.cpp", ln=594) at ../jsutil.cpp:79
#2  0x000000000048b1a2 in js_CloseIterator (cx=0x8bd430, v=140737332126848) at ../jsiter.cpp:594
#3  0x0000000000572da3 in CloseIterator (cx=0x8bd430, iterobj=0x7ffff6b02480) at ../jstracer.cpp:13649

Comment 1

[Andreas Gal :gal]

Missing guard. Easy fix.

Comment 2

[Andreas Gal :gal]

Attachment: patch

We can also just trace and then fall of trace in case of a generator. I think I didn't do this before because of problems with the status exit but it seems to work. Maybe it fails one of gary's cases?

Comment 3

[Andreas Gal :gal]

Gary, can you fuzz TM tip with this patch?

Comment 4

[Robert Sayre]

please re-enable this test once you fix this bug:
http://hg.mozilla.org/tracemonkey/rev/890c0d2e45b3

Comment 5

[Andreas Gal :gal]

Attachment: patch

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 444962 [details] [diff] [review]
patch

reftests and trace-tests pass now.

Comment 7

[Robert Sayre]

http://hg.mozilla.org/tracemonkey/rev/40260d7634a1

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #3)
> Gary, can you fuzz TM tip with this patch?

Patch looks good on 32-bit shells after 12 hours of dedicated fuzz.

Comment 9

[Andreas Gal :gal]

Great, thanks Gary.

Comment 10

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/40260d7634a1

Comment 11

[Jonathan Kew [:jfkthame]]

(In reply to comment #4)
> please re-enable this test once you fix this bug:
> http://hg.mozilla.org/tracemonkey/rev/890c0d2e45b3

Re-enabled by http://hg.mozilla.org/mozilla-central/rev/31fbc861bcb9