Closed Bug 565199 Opened 10 years ago Closed 10 years ago

TM: trace-test failure in testGeneratorDeepBail, x64

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dvander, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

Maybe missing guard for generators?

#2  0x000000000048b1a2 in js_CloseIterator (cx=0x8bd430, v=140737332126848) at ../jsiter.cpp:594
594	        JS_ASSERT_NOT_ON_TRACE(cx);


rogram received signal SIGABRT, Aborted.
0x00007ffff7bcf7bb in raise () from /lib/libpthread.so.0
(gdb) bt
#0  0x00007ffff7bcf7bb in raise () from /lib/libpthread.so.0
#1  0x0000000000527a2c in JS_Assert (s=0x5f069f "!JS_ON_TRACE(cx)", file=0x5f0577 "../jsiter.cpp", ln=594) at ../jsutil.cpp:79
#2  0x000000000048b1a2 in js_CloseIterator (cx=0x8bd430, v=140737332126848) at ../jsiter.cpp:594
#3  0x0000000000572da3 in CloseIterator (cx=0x8bd430, iterobj=0x7ffff6b02480) at ../jstracer.cpp:13649
Assignee: general → gal
Missing guard. Easy fix.
Attached patch patch (obsolete) — Splinter Review
We can also just trace and then fall of trace in case of a generator. I think I didn't do this before because of problems with the status exit but it seems to work. Maybe it fails one of gary's cases?
Gary, can you fuzz TM tip with this patch?
please re-enable this test once you fix this bug:
http://hg.mozilla.org/tracemonkey/rev/890c0d2e45b3
Attached patch patchSplinter Review
Attachment #444806 - Attachment is obsolete: true
Comment on attachment 444962 [details] [diff] [review]
patch

reftests and trace-tests pass now.
Attachment #444962 - Flags: review+
http://hg.mozilla.org/tracemonkey/rev/40260d7634a1
Whiteboard: fixed-in-tracemonkey
(In reply to comment #3)
> Gary, can you fuzz TM tip with this patch?

Patch looks good on 32-bit shells after 12 hours of dedicated fuzz.
Great, thanks Gary.
http://hg.mozilla.org/mozilla-central/rev/40260d7634a1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 485196
(In reply to comment #4)
> please re-enable this test once you fix this bug:
> http://hg.mozilla.org/tracemonkey/rev/890c0d2e45b3

Re-enabled by http://hg.mozilla.org/mozilla-central/rev/31fbc861bcb9
You need to log in before you can comment on or make changes to this bug.