Last Comment Bug 565314 - Cannot edit FIXED bugs when a blocker is open, when "noresolveonopenblockers" is on
: Cannot edit FIXED bugs when a blocker is open, when "noresolveonopenblockers"...
: regression
Product: Bugzilla
Classification: Server Software
Component: Creating/Changing Bugs (show other bugs)
: 3.6
: All All
-- normal (vote)
: Bugzilla 3.6
Assigned To: Frédéric Buclin
: default-qa
Depends on:
  Show dependency treegraph
Reported: 2010-05-12 07:58 PDT by Graeme Coates
Modified: 2010-05-13 06:47 PDT (History)
2 users (show)
mkanat: approval+
mkanat: approval3.6+
LpSolit: blocking3.6.1+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

patch, v1 (812 bytes, patch)
2010-05-12 10:12 PDT, Frédéric Buclin
mkanat: review+
Details | Diff | Splinter Review

Description User image Graeme Coates 2010-05-12 07:58:59 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20100316 Firefox/3.6.2 GTB7.0 (.NET CLR 3.5.30729)
Build Identifier: Bugzilla 3.6


Bug 1 blocks Bug 2
Both are resolved, but subsequently Bug 1 is reopened.

At this point I cannot make any comment on Bug 2 due to the open blocking bug. If I choose to edit Bug 2 and remove the dependency on Bug 1, I get the Error: 

"Bug# 2  still has 1 unresolved dependency. Show Dependency Tree."

However, I can get to exactly the same point by going to Bug 1 and removing the "blocks" entry for bug 2. It seems a little strange that Bugzilla warns me I can't make a change to Bug 2 to remove the dependency because there is a dependency...

Reproducible: Always

Steps to Reproduce:
1. Setup one bug blocking another, and then resolve both.
2. Reopen the blocker.
3. Attempt to edit the blocked bug - not allowed (though actually, no reason why I shouldn't be able to add a comment here IMHO without a status change).
4. Attempt to remove dependency from blocked (resolved) bug - cannot remove dependency due to dependency!
Actual Results:  
Dependency doesn't allow user to remove dependency.

Expected Results:  
Should be able to remove only dependency from a bug that has only one open dependency.
Comment 1 User image Frédéric Buclin 2010-05-12 08:41:53 PDT
Yes, I can reproduce the issue. The noresolveonopenblockers parameter is only supposed to prevent resolving bugs, not preventing any other changes. Probably a regression.
Comment 2 User image Frédéric Buclin 2010-05-12 10:12:40 PDT
Created attachment 444903 [details] [diff] [review]
patch, v1

If the bug is already resolved as FIXED, do not prevent to edit it. No idea which bug regressed this, but I cannot reproduce in Bugzilla 3.4.
Comment 3 User image Max Kanat-Alexander 2010-05-13 06:11:30 PDT
Comment on attachment 444903 [details] [diff] [review]
patch, v1

This looks good. :-)
Comment 4 User image Frédéric Buclin 2010-05-13 06:47:14 PDT
Committing to: bzr+ssh://
modified Bugzilla/
Committed revision 7161.

Committing to: bzr+ssh://
modified Bugzilla/
Committed revision 7095.

Note You need to log in before you can comment on or make changes to this bug.