565314 - Cannot edit FIXED bugs when a blocker is open, when "noresolveonopenblockers" is on

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Graeme Coates]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2 GTB7.0 (.NET CLR 3.5.30729)
Build Identifier: Bugzilla 3.6

Situation:

Bug 1 blocks Bug 2
Both are resolved, but subsequently Bug 1 is reopened.

At this point I cannot make any comment on Bug 2 due to the open blocking bug. If I choose to edit Bug 2 and remove the dependency on Bug 1, I get the Error: 

"Bug# 2  still has 1 unresolved dependency. Show Dependency Tree."

However, I can get to exactly the same point by going to Bug 1 and removing the "blocks" entry for bug 2. It seems a little strange that Bugzilla warns me I can't make a change to Bug 2 to remove the dependency because there is a dependency...




Reproducible: Always

Steps to Reproduce:
1. Setup one bug blocking another, and then resolve both.
2. Reopen the blocker.
3. Attempt to edit the blocked bug - not allowed (though actually, no reason why I shouldn't be able to add a comment here IMHO without a status change).
4. Attempt to remove dependency from blocked (resolved) bug - cannot remove dependency due to dependency!
Actual Results:  
Dependency doesn't allow user to remove dependency.

Expected Results:  
Should be able to remove only dependency from a bug that has only one open dependency.

Comment 1

[Frédéric Buclin]

Yes, I can reproduce the issue. The noresolveonopenblockers parameter is only supposed to prevent resolving bugs, not preventing any other changes. Probably a regression.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

If the bug is already resolved as FIXED, do not prevent to edit it. No idea which bug regressed this, but I cannot reproduce in Bugzilla 3.4.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 444903 [details] [diff] [review]
patch, v1

This looks good. :-)

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 7161.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified Bugzilla/Bug.pm
Committed revision 7095.