565460 - Remove styling for treechildren[alternatingbackground="true"]

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Steffen Wilberg]

Attachment: patch

In bug 282127, I made odd tree rows in trees with multiple columns highlighted in Gnomestripe and Pinstripe.

So there's no need for treechildren[alternatingbackground="true"] anymore, which should be removed therefore.

I removed that attribute from config.xul, so the last consumer is DOM Inspector:
http://mxr.mozilla.org/comm-central/search?string=alternatingbackground&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 444988 [details] [diff] [review]
patch

>-treechildren[alternatingbackground="true"]::-moz-tree-cell-text(odd, selected) {
>-  color: -moz-DialogText;
>-}

Is there an equivalent to this in the multicol styling? If not, why not?

Comment 2

[Steffen Wilberg]

No, there's just the general rule:
111 treechildren::-moz-tree-cell-text(selected) {
112   color: -moz-DialogText;
113 }
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/tree.css#111

I guess the multicol rules don't modify this since they only use ::-moz-tree-row, whereas the alternatingbackground rules also have ::-moz-tree-cell-text(odd, selected, focus). I don't have a Mac to test though.

Comment 3

[Stefan [:stefanh]]

https://developer.mozilla.org/en/XUL/Attribute/alternatingbackground

I'm not sure why this should be removed. Is the support for the attribute removed? If not, why do we remove the styling?

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> https://developer.mozilla.org/en/XUL/Attribute/alternatingbackground
> 
> I'm not sure why this should be removed. Is the support for the attribute
> removed? If not, why do we remove the styling?

The styling and support for the attribute are the same thing.

Comment 5

[Steffen Wilberg]

http://hg.mozilla.org/mozilla-central/rev/e193ca042f86

Comment 6

[[e-mail]]

(In reply to comment #0)
> I removed that attribute from config.xul, so the last consumer is DOM
> Inspector:
> http://mxr.mozilla.org/comm-central/search?string=alternatingbackground&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Well, you somehow managed to overlook the references in /suite/themes/modern/global/tree.css which were expecting to be able to theme about:config and DOM Inspector...

Comment 7

[Steffen Wilberg]

These rules still apply to DOM Inspector. You can add similar rules to Modern's config.css to style about:config. Or port bug 282127, this bug and bug 566178 to tree.css to style all multi-column trees.

Comment 8

[Eric Shepherd [:sheppy]]

Updated documentation:

https://developer.mozilla.org/en/XUL/Attribute/alternatingbackground

And mentioned here:

https://developer.mozilla.org/en/Firefox_4_for_developers#Miscellaneous_XUL_changes