Closed Bug 565521 Opened 10 years ago Closed 10 years ago

TM: foreach loops need to call the getter on the original object instead of the prototype

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(2 files)

This is the bug in test_feed_discovery.html: we're calling the getter on the (XPCWrappedNative) prototype instead of the wrappednative itself and XPConnect can't deal. Easy fix upcoming.
Attached patch FixSplinter Review
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #445012 - Flags: review?(gal)
Attachment #445012 - Flags: review?(gal) → review+
Version: 1.9.1 Branch → Trunk
Comment on attachment 445012 [details] [diff] [review]
Fix

Argh. I so should have caught this, it's the elephant in the room.

/be
this needs a test for this specific problem in trace-tests or js-reftests.
Attached patch TestSplinter Review
Attachment #445024 - Flags: review?(sayrer)
Attachment #445024 - Flags: review?(sayrer) → review+
http://hg.mozilla.org/mozilla-central/rev/2b6cdb2d544d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.