565554 - Fix GCC warnings in nsExternalHelperAppService.cpp

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Daniel Holbert [:dholbert]]

nsExternalHelperAppService.cpp currently has these build warnings:
{
> uriloader/exthandler/nsExternalHelperAppService.h: In constructor ‘nsExternalAppHandler::nsExternalAppHandler(nsIMIMEInfo*, const nsCSubstring&, nsIInterfaceRequestor*, const nsAString_internal&, PRUint32, PRBool)’:
> uriloader/exthandler/nsExternalHelperAppService.h:445: warning: ‘nsExternalAppHandler::mRequest’ will be initialized after
> uriloader/exthandler/nsExternalHelperAppService.h:356: warning:   ‘char* nsExternalAppHandler::mDataBuffer’
> uriloader/exthandler/nsExternalHelperAppService.cpp:1098: warning:   when initialized here
> uriloader/exthandler/nsExternalHelperAppService.cpp:1133: warning: comparison between signed and unsigned integer expressions
}

Filing this bug on fixing them.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: trivial fix

Two-line patch to fix the warnings.

Flagging dougt for review, since the first warning is from his checkin. (tsk tsk :))

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 445030 [details] [diff] [review]
trivial fix

doh.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to comment #3)
> 
> *** This bug has been marked as a duplicate of bug 562415 ***

ah, sorry -- didn't notice the duping, & landed patch:
http://hg.mozilla.org/mozilla-central/rev/6e98f21c7b61

(I searched for the filename nsExternalAppHandlerService.cpp when filing to catch dupes, but that failed because the other bug used class name instead of filename.  My bad for making my search too specific.)

Resolving as fixed, and reversing the duping, since the patch that landed had this bug in the commit message.