565582 - Remove nsIAuthPrompt / nsIAuthPrompt2 implementation from login manager

Status: NEW

(Toolkit :: Password Manager, defect, P5)

Description

[Justin Dolske [:Dolske]]

The integration of login manager with our prompting framework has always bugged me, as it's needlessly confusing.

EG:

1) Caller invokes nsIPromptService's getPrompt(), requesting a nsIAuthPrompt[2].
2) The prompt service delegates to pwmgr's nsIPromptFactory
3) Caller is given a pwmgr implementation of nsIAuthPrompt[2]
4) Caller invokes, say, promptUsernameAndPassword
5) Pwmgr sets up some strings and may autofill a login
6) Pwmgr  invokes nsIPromptService's promptUsernameAndPassword
...user deals with dialog...
7) Prompt service's dialog returns, pwmgr may save a login
8) Pwmgr returns a result to original caller.

I think it would be a simpler architecture to have the prompt service handle all the prompt-specific bits, and login manager should use an observer or events to handle (1) filling in a dialog before it's shown and (2) saving data from a dialog after it's dismissed.

EG:

1) Caller invokes nsIPromptService's getPrompt()
2) Prompt service returns an instance of it's nsIAuthPrompt[2].
3) Caller invokes, say, promptUsernameAndPassword
4) Prompt service notifies "beforeAuthDialog" observers
5) Pwmgr's observer may prefill the dialog with a login
...user deals with dialog...
6) Prompt service notifies "afterAuthDialog" observers
7) Pwmgr's observer may save the entered login

Comment 1

[Justin Dolske [:Dolske]]

I should note that the fix for this would also involve moving login manger's asyncPromptAuth stuff over to to prompt service. nsLoginManagerPrompter would mostly just be an observer for the various prompt types.

Comment 2

[Cristian Nicolae (:xti)]

Attachment: screenshot

This error occurs on:
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:6.0a2)Gecko/20110705
Firefox/6.0a2 Fennec/6.0a2
Device: Motorola Droid 2
OS: Android 2.2

Steps to reproduce:
1. Open Fennec app
2. Go to https://fisheye.last.fm/
3. Tap on the "I Understand the Risks" > "Add permanent exception"
4. Tap cancel on the dialog

Actual result:
In console I've found this error:
Error: [Exception... "'Method not implemented' when calling method:
[nsIAuthPrompt2::asyncPromptAuth]" nsresult: "0x80004001 
(NS_ERROR_NOT_IMPLEMENTED)" location: "<unknown>" data: no]