Closed
Bug 565599
Opened 15 years ago
Closed 15 years ago
unused variable nsNavHistoryContainerResultNode::mAsyncEnabled
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla2.0b1
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file, 1 obsolete file)
|
659 bytes,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Summary: unused variable nsNavHistoryResult::mAsyncEnabled → unused variable nsNavHistoryContainerResultNode::mAsyncEnabled
Attachment #445075 -
Attachment is obsolete: true
Attachment #445076 -
Flags: review?(mano)
Attachment #445075 -
Flags: review?(mano)
|
||
Comment 3•15 years ago
|
||
it looks used to me, maybe it's just not initialized to a correct value in the constructor?
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistoryQuery.cpp#1575
result->mAsyncEnabled = mAsyncEnabled;
|
|
||
Comment 4•15 years ago
|
||
correct value == PR_FALSE
that's:
122 class nsNavHistoryQueryOptions : public nsINavHistoryQueryOptions
179 PRBool mAsyncEnabled
which just looks the same but is different :)
|
|
||
Comment 6•15 years ago
|
||
oh you're right, I was confused by the stupidity of this code:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistoryQuery.cpp#1562
nsNavHistoryQueryOptions *result = new nsNavHistoryQueryOptions();
How can someone call result what really is options...
|
|
||
Updated•15 years ago
|
Attachment #445076 -
Flags: review?(mano) → review+
|
|
||
Updated•15 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•15 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a6
|
|
||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•