Closed Bug 565599 Opened 10 years ago Closed 10 years ago

unused variable nsNavHistoryContainerResultNode::mAsyncEnabled

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b1

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: 536893
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #445075 - Flags: review?(mano)
Summary: unused variable nsNavHistoryResult::mAsyncEnabled → unused variable nsNavHistoryContainerResultNode::mAsyncEnabled
Attachment #445075 - Attachment is obsolete: true
Attachment #445076 - Flags: review?(mano)
Attachment #445075 - Flags: review?(mano)
it looks used to me, maybe it's just not initialized to a correct value in the constructor?

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistoryQuery.cpp#1575
result->mAsyncEnabled = mAsyncEnabled;
correct value == PR_FALSE
that's:
122 class nsNavHistoryQueryOptions : public nsINavHistoryQueryOptions
179   PRBool mAsyncEnabled

which just looks the same but is different :)
oh you're right, I was confused by the stupidity of this code:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/src/nsNavHistoryQuery.cpp#1562
nsNavHistoryQueryOptions *result = new nsNavHistoryQueryOptions();

How can someone call result what really is options...
Attachment #445076 - Flags: review?(mano) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/a3c93038c26a
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.