Closed Bug 565608 Opened 10 years ago Closed 10 years ago

dead code in UnrolledMatch

Categories

(Core :: JavaScript Engine, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED INVALID

People

(Reporter: timeless, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

1126 UnrolledMatch(const jschar *text, jsuint textlen, const jschar *pat, jsuint patlen)
1146     while (t != textend) {
1154       if (t[7] == p0) { t += 8; fixup = 1; goto match; }
1155         t += 8;
1156         continue;

this do loop is unreachable:
1157         do {
1158             if (*t++ == p0) {
1159               match:
1160                 if (!InnerMatch::match(patNext, t, extent))
1161                     goto failed_match;
1162                 return t - text - 1;
1163             }
1164           failed_match:;
1165         } while (--fixup > 0);
1166     }
hrm, no, it isn't unreachable, coverity is confused :(
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.