dead code in UnrolledMatch

RESOLVED INVALID

Status

()

Core
JavaScript Engine
--
minor
RESOLVED INVALID
8 years ago
8 years ago

People

(Reporter: timeless, Unassigned)

Tracking

({coverity})

Trunk
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

8 years ago
1126 UnrolledMatch(const jschar *text, jsuint textlen, const jschar *pat, jsuint patlen)
1146     while (t != textend) {
1154       if (t[7] == p0) { t += 8; fixup = 1; goto match; }
1155         t += 8;
1156         continue;

this do loop is unreachable:
1157         do {
1158             if (*t++ == p0) {
1159               match:
1160                 if (!InnerMatch::match(patNext, t, extent))
1161                     goto failed_match;
1162                 return t - text - 1;
1163             }
1164           failed_match:;
1165         } while (--fixup > 0);
1166     }
(Reporter)

Comment 1

8 years ago
hrm, no, it isn't unreachable, coverity is confused :(
(Reporter)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.