565617 - nsChannelPolicy::nsChannelPolicy() should initialize mLoadType

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[timeless]

NS_GENERIC_FACTORY_CONSTRUCTOR(nsChannelPolicy) 

61     unsigned long mLoadType;

39 nsChannelPolicy::nsChannelPolicy()
40 {
41 }

Comment 1

[timeless]

Attachment: initialize with 0 (which is not a defined nsIContentPolicy type)

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 445089 [details] [diff] [review]
initialize with 0 (which is not a defined nsIContentPolicy type)

you should ask bsterne for reviewing this patch

Comment 3

[Brandon Sterne (:bsterne)]

Comment on attachment 445089 [details] [diff] [review]
initialize with 0 (which is not a defined nsIContentPolicy type)

Makes sense to me. r=bsterne

Comment 4

[timeless]

http://hg.mozilla.org/mozilla-central/rev/928c1026aeb4

Comment 5

[Tanvi Vyas[:tanvi]]

This means we are failing open.  Two questions:
1) Are there content types that we should set (maybe there is a new CSP directive for them?) that aren't being set.

2) For the content types that are set (ex: script) how do we know they are set in all places?