Closed Bug 565617 Opened 10 years ago Closed 10 years ago

nsChannelPolicy::nsChannelPolicy() should initialize mLoadType

Categories

(Core :: DOM: Core & HTML, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

NS_GENERIC_FACTORY_CONSTRUCTOR(nsChannelPolicy) 

61     unsigned long mLoadType;

39 nsChannelPolicy::nsChannelPolicy()
40 {
41 }
Blocks: 515797
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #445089 - Flags: review?(cbiesinger)
Comment on attachment 445089 [details] [diff] [review]
initialize with 0 (which is not a defined nsIContentPolicy type)

you should ask bsterne for reviewing this patch
Attachment #445089 - Flags: review?(cbiesinger)
Attachment #445089 - Flags: review?(bsterne)
Comment on attachment 445089 [details] [diff] [review]
initialize with 0 (which is not a defined nsIContentPolicy type)

Makes sense to me. r=bsterne
Attachment #445089 - Flags: review?(bsterne) → review+
http://hg.mozilla.org/mozilla-central/rev/928c1026aeb4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This means we are failing open.  Two questions:
1) Are there content types that we should set (maybe there is a new CSP directive for them?) that aren't being set.

2) For the content types that are set (ex: script) how do we know they are set in all places?
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.