565708 - [OOPP] Slow loading plugins crash [@ hang | mozilla::plugins::PPluginInstanceParent::CallNPP_SetWindow(mozilla::plugins::NPRemoteWindow const&) ]

Status: VERIFIED WONTFIX

(Core Graveyard :: Plug-ins, defect)

Description

[Vlad Alexander]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100513 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100513 Minefield/3.7a5pre

We noticed that our plugin started to crash in nightly builds of Firefox when the plugin takes some time to load. Our plugin often needs to download external configuration files while loading and this can take some time for various reasons.

Reproducible: Always

Steps to Reproduce:
1. Download and install the plugin from here:
http://misc.xstandard.com/mozilla/NPXStandard.dll

2. Go to this page which will load the plugin:
http://misc.xstandard.com/mozilla/slowload.htm

The plug-in will try to download a configuration file which will take 10 seconds.
Actual Results:  
The plug-in will crash.

Expected Results:  
The plug-in should not crash.

This is a regression.

Comment 1

[Ria Klaassen (not reading all bugmail)]

http://crash-stats.mozilla.com/report/index/2783da2a-18b4-455a-b62a-dc6e62100513

0  	ntdll.dll  	KiFastSystemCallRet  	
1 	ntdll.dll 	NtWaitForSingleObject 	
2 	kernel32.dll 	WaitForSingleObjectEx 	
3 	kernel32.dll 	WaitForSingleObject 	
4 	xul.dll 	google_breakpad::ExceptionHandler::WriteMinidumpOnHandlerThread 	toolkit/crashreporter/google-breakpad/src/client/windows/handler/exception_handler.cc:691
5 	xul.dll 	google_breakpad::ExceptionHandler::WriteMinidumpForException 	toolkit/crashreporter/google-breakpad/src/client/windows/handler/exception_handler.cc:706
6 	xul.dll 	google_breakpad::ExceptionHandler::WriteMinidump 	toolkit/crashreporter/google-breakpad/src/client/windows/handler/exception_handler.cc:748
7 	xul.dll 	CrashReporter::CreatePairedMinidumps 	toolkit/crashreporter/nsExceptionHandler.cpp:1729
8 	xul.dll 	mozilla::plugins::PluginModuleParent::ShouldContinueFromReplyTimeout 	dom/plugins/PluginModuleParent.cpp:227
9 	xul.dll 	mozilla::ipc::SyncChannel::ShouldContinueFromTimeout 	ipc/glue/SyncChannel.cpp:261
10 	xul.dll 	mozilla::ipc::RPCChannel::Call 	ipc/glue/RPCChannel.cpp:210
11 	xul.dll 	mozilla::plugins::PPluginInstanceParent::CallNPP_SetWindow 	obj-firefox/ipc/ipdl/PPluginInstanceParent.cpp:203
12 	xul.dll 	mozilla::plugins::PluginInstanceParent::NPP_SetWindow 	dom/plugins/PluginInstanceParent.cpp:534
13 	xul.dll 	mozilla::plugins::PluginModuleParent::NPP_SetWindow 	dom/plugins/PluginModuleParent.cpp:418
14 	xul.dll 	nsNPAPIPluginInstance::SetWindow 	modules/plugin/base/src/nsNPAPIPluginInstance.cpp:1259
15 	xul.dll 	nsPluginNativeWindow::CallSetWindow 	obj-firefox/dist/include/nsPluginNativeWindow.h:101
16 	xul.dll 	nsPluginNativeWindowWin::CallSetWindow 	modules/plugin/base/src/nsPluginNativeWindowWin.cpp:521
17 	xul.dll 	nsPluginHost::InstantiateEmbeddedPlugin 	modules/plugin/base/src/nsPluginHost.cpp:2300
18 	xul.dll 	nsObjectFrame::InstantiatePlugin 	layout/generic/nsObjectFrame.cpp:967
19 	xul.dll 	nsObjectFrame::Instantiate 	layout/generic/nsObjectFrame.cpp:2096
20 	xul.dll 	nsObjectLoadingContent::Instantiate 	content/base/src/nsObjectLoadingContent.cpp:1908
21 	xul.dll 	nsAsyncInstantiateEvent::Run 	content/base/src/nsObjectLoadingContent.cpp:165
22 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:527
23 	xul.dll 	mozilla::ipc::MessagePump::Run 	ipc/glue/MessagePump.cpp:118
24 	xul.dll 	xul.dll@0x9bc2ab 	
25 	xul.dll 	MessageLoop::RunInternal 	ipc/chromium/src/base/message_loop.cc:216
26 	xul.dll 	MessageLoop::RunHandler 	ipc/chromium/src/base/message_loop.cc:199
27 	user32.dll 	UserCallWinProcCheckWow 	
28 	xul.dll 	xul.dll@0x31aee3 	
29 	xul.dll 	xul.dll@0x333d1e 	
30 	firefox.exe 	firefox.exe@0x1bc7 	
31 	ntdll.dll 	WinSqmStartSession 	
32 	ntdll.dll 	_RtlUserThreadStart 	
33 	firefox.exe 	firefox.exe@0x186f 	
34 	firefox.exe 	firefox.exe@0x186f

Comment 2

[Ria Klaassen (not reading all bugmail)]

It crashes only with dom.ipc.plugins.enabled to true.

Comment 3

[timeless]

vlad: you're actually hitting a hang detector, we hope that you'd either use the npapi to request network bits or use a thread....

Comment 4

[Benjamin Smedberg]

This is by design. Any NPAPI call which takes longer than 10 seconds will cause us to kill off the misbehaving plugin. You should refactor you code to make your network requests asynchronously.

Comment 5

[Vlad Alexander]

>You should refactor you code to make your network requests asynchronously.
That is easy to say after the fact but there are over a million of our plug-ins in use and the behavior _change_ in Firefox may affect many users.

Can you do the following:

1. Don't close this bug until we have had time to investigate the suggestions in comment #3.

2. For the time being (a year or so), change the 10 seconds to 20.

Comment 6

[Benjamin Smedberg]

This change will not show up in a release build until Firefox 4, scheduled for beta in June and release in... October-November. You have until then!

No, we are not going to increase the timeout.

Comment 7

[Vlad Alexander]

Displaying a crash message to users will cause us significant tech support issues. Our tech support, working remotely with non-technical users, will not be able to determine if the plug-in really crashed or just took too long to load. Can you please change the message to something like "The XXX plugin is taking too long to load" and because this is not a crash, remove the link to "Send crash report"?

Comment 8

[Benjamin Smedberg]

No. From a user perspective they are treated the same (and we do collect crash reports for hangs).

Comment 10

[Jo Hermans]

Bug 575183 still saw the slow-load problem, even in Firefox 3.6.6, which increased the timeout to 45 seconds.

Comment 11

[Rob]

I'm getting this in 3.6.8 (Namoroka Nightly) both on page https://www.xoticpc.com/ (which is apparently loading too slow) _AND_ also on http://sites.amd.com/us/fusion/apu/Pages/fusion.aspx which I would have hoped would not have had this issue.


I also get pop-ups from Flash that say various things and am offered the choice to [Continue] or [Dismiss], here is the output from one such pop-up; doesn't look good:

Error #2044: Unhandled securityError:. text=Error #2048: Security sandbox violation: http://sites.amd.com/PublishingImages/Public/Flash/VerticalFlash/AMDSfyPlayer.swf cannot load data from http://web.amd.com/assets/fusionapuvideoplayer/fusionapuvideoplayer.xml.
	at com.amd.sfyplayer.controller::Controller/startup()
	at AMDSfyPlayer/launch()
	at AMDSfyPlayer/onCSSLoadComplete()
	at flash.events::EventDispatcher/dispatchEventFunction()
	at flash.events::EventDispatcher/dispatchEvent()
	at asu.style::ASStyleCSSLoader/onCSSFileLoaded()
	at flash.events::EventDispatcher/dispatchEventFunction()
	at flash.events::EventDispatcher/dispatchEvent()
	at flash.net::URLLoader/onComplete()

I "don't have the bits" to re-open or I would, and I'll not file a new report since it has already been decided "WONTFIX" but I do think there is a problem.

Rob

Comment 12

[timeless]

so, you don't have the bits to reopen because you don't understand how and when things should be reopened, this isn't such a case.

the security error is flash saying "the developers of this website are idiots". it has nothing to do with us. What you should do is take the error you pasted in comment 11 and send it to someone at amd.com, i can't find a great venue for reporting bugs, you could try:
http://forums.amd.com/forum/categories.cfm?catid=41

but i wouldn't expect much from them, there's an item there were someone asked for a favicon for that site, and someone thought that it would happen "soon", that was 18months ago.

Comment 13

[WL]

https://crash-stats.mozilla.com/report/index/bp-0d7af85a-bc32-458b-bd29-3e7372110517
Visit http://paulrouget.com/e/emulators/
It hangs in nightly and works fine in Chrome.

Comment 14

[dindog]

plugin hang when click if dom.plugins.ipc.enabled is enable since 20110519 nightly.

see bug658741

Comment 15

[Mikel]

Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110524 Firefox/6.0a1

Nighty Just crashed on me right now:
https://crash-stats.mozilla.com/report/index/e529ecc3-cfb0-41a2-9b85-e8a152110524

Comment 16

[shawn.sumin]

https://crash-stats.mozilla.com/report/index/f39c4dc8-25b7-4bec-80f8-081a12110725

This is in 6.0 Beta