565745 - JM: mochitest-plain failure: /tests/content/base/test/test_bug353334.html

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

6166 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug353334.html | Wrong principal for document in node with id='one' - got [xpconnect wrapped (nsISupports, nsIPrincipal, nsISerializable) @ 0x673dcb0 (native @ 0x9537f38)], expected [xpconnect wrapped (nsISupports, nsIPrincipal, nsISerializable) @ 0x6748e38 (native @ 0x9537f38)]

+ 4 more failures just like it.

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Patch 2

The cause was that jsl_Equality didn't include the equality hook case (probably because I couldn't easily test it in those early days). This test gets back 2 nodePrincipal values and tries to compare them. The nsNodePrincipal pointers are equal, but the JSObject* pointers are not; this test case relies on the equality hook to make them equal.

Comment 2

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/users/danderson_mozilla.com/jaegermonkey/file/e30a523ab604