Closed Bug 565745 Opened 14 years ago Closed 14 years ago

JM: mochitest-plain failure: /tests/content/base/test/test_bug353334.html

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dmandelin, Assigned: dmandelin)

References

Details

Attachments

(1 file)

6166 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug353334.html | Wrong principal for document in node with id='one' - got [xpconnect wrapped (nsISupports, nsIPrincipal, nsISerializable) @ 0x673dcb0 (native @ 0x9537f38)], expected [xpconnect wrapped (nsISupports, nsIPrincipal, nsISerializable) @ 0x6748e38 (native @ 0x9537f38)]

+ 4 more failures just like it.
Attached patch Patch 2Splinter Review
The cause was that jsl_Equality didn't include the equality hook case (probably because I couldn't easily test it in those early days). This test gets back 2 nodePrincipal values and tries to compare them. The nsNodePrincipal pointers are equal, but the JSObject* pointers are not; this test case relies on the equality hook to make them equal.
Attachment #445230 - Flags: review?(dvander)
Attachment #445230 - Flags: review?(dvander) → review+
http://hg.mozilla.org/users/danderson_mozilla.com/jaegermonkey/file/e30a523ab604
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: